Source/modules/push_messaging/PushManager.cpp - Issue 676003002: Add layout tests for hasPermission

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/push_messaging/PushManager.cpp

Issue 676003002: Add layout tests for hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@push_has_permission

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/modules/push_messaging/PushManager.cpp

diff --git a/Source/modules/push_messaging/PushManager.cpp b/Source/modules/push_messaging/PushManager.cpp

index e55b22d5e9a80a77564cf1eeb90c5a0a253541ef..a30a210a622edf2cd58ba9533a57364f23f4df9b 100644

--- a/Source/modules/push_messaging/PushManager.cpp

+++ b/Source/modules/push_messaging/PushManager.cpp

@@ -72,8 +72,9 @@ ScriptPromise PushManager::hasPermission(ScriptState* scriptState)

RefPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);

+ ScriptPromise promise = resolver->promise();

client->getPermissionStatus(new PushPermissionCallback(resolver), serviceWorkerProvider);

- return resolver->promise();

+ return promise;

}

} // namespace blink