LayoutTests/push_messaging/push-messaging-has-permission.html - Issue 676003002: Add layout tests for hasPermission

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/push_messaging/push-messaging-has-permission.html

Issue 676003002: Add layout tests for hasPermission (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@push_has_permission

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/push_messaging/push-messaging.html ('K') | « LayoutTests/push_messaging/push-messaging-expected.txt ('k') | LayoutTests/push_messaging/push-messaging-has-permission-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src='../resources/js-test.js'></script>
	Michael van Ouwerkerk 2014/10/24 12:53:01 nit: double quotes for html attributes please nit: double quotes for html attributes please Miguel Garcia 2014/10/31 17:04:47 Done. Show quoted text On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote: > nit: double quotes for html attributes please Done.
	5 </head>

	6 <body>

	7 <script>

	8 description('Tests for the Push API has permission method.');
	Michael van Ouwerkerk 2014/10/24 12:53:01 hasPermission hasPermission Miguel Garcia 2014/10/31 17:04:47 Done. Show quoted text On 2014/10/24 12:53:01, Michael van Ouwerkerk wrote: > hasPermission Done.
	9

	10 if (!window.testRunner)

	11 debug('This test can not run without testRunner');

	12

	13 window.jsTestIsAsync = true;

	14

	15 function testPushHasPermissionDefault() {

	16 window.testRunner.setMockPushClientError('permission_default');

	17 testPushHasPermission('default', testPushHasPermissionDenied);

	18 }

	19

	20 function testPushHasPermissionDenied() {

	21 window.testRunner.setMockPushClientError('deny_permission');

	22 testPushHasPermission('denied', testPushHasPermissionGranted);

	23 }

	24

	25 function testPushHasPermissionGranted() {

	26 window.testRunner.setMockPushClientSuccess('endpoint', 'registrationId');

	27 testPushHasPermission('granted');

	28 }

	29

	30 function testPushHasPermission(expectedStatus, runNext) {

	31 navigator.push.hasPermission().then(function(permissionStatus) {

	32 status = permissionStatus;
	Peter Beverloo 2014/10/24 13:03:24 nit: double space before the = nit: double space before the = Miguel Garcia 2014/10/31 17:04:47 Done. Show quoted text On 2014/10/24 13:03:24, Peter Beverloo wrote: > nit: double space before the = Done.
	33 shouldBeEqualToString('status', expectedStatus);
	Peter Beverloo 2014/10/24 13:03:24 shouldBeEqualToString('status', 'expectedStatus') shouldBeEqualToString('status', 'expectedStatus') Miguel Garcia 2014/10/31 17:04:47 Oh, here it still matters, see previous comment. Show quoted text On 2014/10/24 13:03:24, Peter Beverloo wrote: > shouldBeEqualToString('status', 'expectedStatus') Oh, here it still matters, see previous comment.
	34 if (runNext)

	35 runNext();

	36 else

	37 finishJSTest();

	38 }, function() {

	39 testFailed('Error callback invoked unexpectedly.');
	Peter Beverloo 2014/10/24 13:03:24 s/Error callback invoked/Promise rejected/. s/Error callback invoked/Promise rejected/. Miguel Garcia 2014/10/31 17:04:47 Done Done
	40 finishJSTest();

	41 });

	42 }

	43

	44 testPushHasPermissionDefault();

	45

	46 </script>

	47 </body>

	48 </html>

OLD	NEW