components: add wifi_sync component

components/wifi_sync/wifi_credential_syncable_service_factory.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_FACTORY_H_
+#define COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_FACTORY_H_
+
+#include "base/basictypes.h"

[erikwright (departed), 2014/10/29 18:18:25]

I believe "macros.h" is now the direct line for DISALLOW_...

[mukesh agrawal, 2014/10/30 18:41:29]

Dropping this file for now, per comment from erg@.

+#include "base/memory/singleton.h"
+#include "components/keyed_service/content/browser_context_keyed_service_factory.h"
+
+class Profile;
+
+namespace wifi_sync {
+
+class WifiCredentialSyncableService;
+
+// Singleton that owns all WifiCredentialSyncableServices and
+// associates them with Profiles. Listens for the Profile's
+// destruction notification and cleans up the associated
+// WifiCredentialSyncableServices.
+class WifiCredentialSyncableServiceFactory
+    : public BrowserContextKeyedServiceFactory {
+ public:
+  static WifiCredentialSyncableService* GetForProfile(Profile* profile);
+
+  static WifiCredentialSyncableServiceFactory* GetInstance();
+
+  static KeyedService* BuildInstanceFor(

[pavely, 2014/10/30 00:25:38]

You've stubbed more functions than absolutely necessary, In the future it is
easier to forget removing unused functions than to forget adding necessary ones.
I would start this class with just GetInstance/GetForProfile, ctor/dtor and
BuildServiceInstanceFor.

[mukesh agrawal, 2014/10/30 18:41:29]

Acknowledged.

+      content::BrowserContext* browser_context);
+
+ private:
+  friend struct DefaultSingletonTraits<WifiCredentialSyncableServiceFactory>;
+
+  WifiCredentialSyncableServiceFactory();
+  ~WifiCredentialSyncableServiceFactory() override;

[erikwright (departed), 2014/10/29 18:18:25]

I don't believe override is technically correct here.

And explicitly mark 'virtual'.

[Elliot Glaysher, 2014/10/29 19:41:18]

override is the correct thing here. You should not mark this as virtual. This is
currently being mass-converted across the code base.

[mukesh agrawal, 2014/10/30 18:41:29]

Acknowledged.

+
+  // BrowserContextKeyedServiceFactory:
+  KeyedService* BuildServiceInstanceFor(
+      content::BrowserContext* context) const override;
+  content::BrowserContext* GetBrowserContextToUse(
+      content::BrowserContext* context) const override;
+
+  DISALLOW_COPY_AND_ASSIGN(WifiCredentialSyncableServiceFactory);
+};
+
+}  // namespace wifi_sync
+
+#endif  // COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_FACTORY_H_