components: add wifi_sync component

components/wifi_sync/wifi_credential_syncable_service.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/wifi_sync/wifi_credential_syncable_service.h"
+
+namespace wifi_sync {
+
+WifiCredentialSyncableService::WifiCredentialSyncableService(
+    content::BrowserContext* context)
+    : browser_context_(context) {
+}
+
+WifiCredentialSyncableService::~WifiCredentialSyncableService() {
+}
+
+// Implementation of syncer::SyncableService API.
+
+syncer::SyncMergeResult WifiCredentialSyncableService::MergeDataAndStartSyncing(
+    syncer::ModelType type,
+    const syncer::SyncDataList& initial_sync_data,
+    scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
+    scoped_ptr<syncer::SyncErrorFactory> error_handler) {
+  NOTIMPLEMENTED();

[erikwright (departed), 2014/10/29 18:18:25]

Is this a work-in-progress, or ready for review?

[mukesh agrawal, 2014/10/30 18:41:28]

While these implementations are just stubs, I think it makes sense to land these
stubs.

The values of these stubs is:
1. Having them in place will make it possible for me to iterate on the two
halves of WiFi credential syncing separately. (One half is implementing this
class, the other is the code that calls this class.)
2. The full implementation + tests is too large for a single CL. Getting the
stubs in place let's me add other pieces in small CLs.
3. There was some concern that adding a new component just for WifiSecurityClass
would be hard to justify. Adding this stub class makes the point of having
wifi_sync clearer.

How does that sound?

[mukesh agrawal, 2014/10/30 20:44:54]

One more thought... Since these are just stubs, you might ask if the stubbed
interface is correct.

The answer to that is that each method is either a) specified by the
SyncableService API, b) a stub extracted from an implementation that I've
already written, or c) both. 

(For methods in case b, I can't fit the implementations in this CL, and still
keep the CL reasonably sized.)

[Elliot Glaysher, 2014/10/31 20:39:07]

I think you should just remove this file, and come back and add a real
implementation later.

+  return syncer::SyncMergeResult(type);
+}
+
+void WifiCredentialSyncableService::StopSyncing(syncer::ModelType type) {
+  NOTIMPLEMENTED();
+}
+
+syncer::SyncDataList WifiCredentialSyncableService::GetAllSyncData(
+    syncer::ModelType type) const {
+  NOTIMPLEMENTED();
+  return syncer::SyncDataList();
+}
+
+syncer::SyncError WifiCredentialSyncableService::ProcessSyncChanges(
+    const tracked_objects::Location& from_here,
+    const syncer::SyncChangeList& change_list) {
+  NOTIMPLEMENTED();
+  return syncer::SyncError();
+}
+
+// Methods called from UI layer.
+
+bool WifiCredentialSyncableService::IsRunning() {
+  NOTIMPLEMENTED();
+  return false;
+}
+
+void WifiCredentialSyncableService::AddToSyncedNetworks(
+    const std::string& item_id,
+    const std::vector<unsigned char>& ssid,
+    WifiSecurityClass security_class,
+    const std::string& passphrase) {
+  NOTIMPLEMENTED();
+}
+
+void WifiCredentialSyncableService::RemoveFromSyncedNetworks(
+    const std::string& item_id) {
+  NOTIMPLEMENTED();
+}
+
+// static
+const char* WifiCredentialSyncableService::GetNormalizedSecurityClass(
+    WifiSecurityClass security_class) {
+  NOTIMPLEMENTED();
+  return nullptr;
+}
+
+}  // namespace wifi_sync