components: add wifi_sync component

components/wifi_sync/wifi_credential_syncable_service.h

+// Copyright (c) 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_H_
+#define COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_H_
+
+#include <string>
+#include <vector>
+
+#include "components/keyed_service/core/keyed_service.h"
+#include "components/wifi_sync/wifi_security_class.h"
+#include "sync/api/sync_change.h"
+#include "sync/api/sync_data.h"
+#include "sync/api/sync_error.h"
+#include "sync/api/sync_error_factory.h"
+#include "sync/api/syncable_service.h"
+
+namespace content {
+class BrowserContext;
+}  // content
+
+namespace wifi_sync {
+
+class WifiCredentialSyncableService
+    : public syncer::SyncableService, public KeyedService {
+ public:
+  explicit WifiCredentialSyncableService(content::BrowserContext *context);
+  virtual ~WifiCredentialSyncableService();

[stevenjb, 2014/10/28 21:17:31]

new style is:
~WifiCredentialSyncableService() override;

Also, no 'virtual' for overrides below.

[mukesh agrawal, 2014/10/29 00:41:34]

Done.

+
+  // syncer::SyncableService implementation.
+  virtual syncer::SyncMergeResult MergeDataAndStartSyncing(
+      syncer::ModelType type,
+      const syncer::SyncDataList& initial_sync_data,
+      scoped_ptr<syncer::SyncChangeProcessor> sync_processor,
+      scoped_ptr<syncer::SyncErrorFactory> error_handler) override;
+  virtual void StopSyncing(syncer::ModelType type) override;
+  virtual syncer::SyncDataList GetAllSyncData(
+      syncer::ModelType type) const override;
+  virtual syncer::SyncError ProcessSyncChanges(
+      const tracked_objects::Location& from_here,
+      const syncer::SyncChangeList& change_list) override;
+
+  // Called from UI layer.
+  virtual bool IsRunning();

[stevenjb, 2014/10/28 21:17:31]

nit: New virtuals should probably be declared first, with a brief explanation of
why they are virtual (for tests?).

[mukesh agrawal, 2014/10/29 00:41:34]

I actually don't know why I made these virtual, so I removed that. Since they're
no longer virtual, I left them where they were. Let me know if they should still
be moved.

[stevenjb, 2014/10/29 17:49:45]

I personally tend to put new public methods above overrides, but I don't think
that's part of the style guide, just my own style, so they're fine here.

+  virtual void AddToSyncedNetworks(
+      const std::string& item_id,
+      const std::vector<unsigned char>& ssid,
+      WifiSecurityClass security_class,
+      const std::string& passphrase);
+  virtual void RemoveFromSyncedNetworks(const std::string& item_id);
+  static const char* GetNormalizedSecurityClass(
+      WifiSecurityClass security_class);
+
+ private:
+  content::BrowserContext *browser_context_;
+
+  DISALLOW_COPY_AND_ASSIGN(WifiCredentialSyncableService);
+};
+
+}  // namespace wifi_sync
+
+#endif  // COMPONENTS_WIFI_SYNC_WIFI_CREDENTIAL_SYNCABLE_SERVICE_H_