Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(717)

Issue 675993003: Explain the reason why we're using isSimpleOrForbiddenRequest() in makeCrossOriginAccessRequest() (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
sof
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Explain the reason why we're using isSimpleOrForbiddenRequest() in makeCrossOriginAccessRequest() This change was made by https://codereview.chromium.org/379113002 Explain the reason in a comment for readability. R=sigbjornf BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184368

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/core/loader/DocumentThreadableLoader.cpp View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-24 13:56:59 UTC) #2
sof
lgtm
6 years, 2 months ago (2014-10-24 14:13:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675993003/1
6 years, 2 months ago (2014-10-24 14:15:16 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 16:10:11 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184368

Powered by Google App Engine
This is Rietveld 408576698