PerformanceTests/ShadowDOM/ChangingSelect.html - Issue 675983004: Allow performance tests to test full rendering performance

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: PerformanceTests/ShadowDOM/ChangingSelect.html

Issue 675983004: Allow performance tests to test full rendering performance (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: PerfTestRunner.layoutOrFullyRender() Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « PerformanceTests/ShadowDOM/ChangingClassNameShadowDOM.html ('k') | PerformanceTests/ShadowDOM/ChangingSelectWithoutShadow.html » ('j') | PerformanceTests/resources/runner.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <script type="text/javascript" src="../resources/runner.js"></script>	4 <script type="text/javascript" src="../resources/runner.js"></script>

5 </head>	5 </head>

6 <body>	6 <body>

7	7

8 <div id="wrapper">	8 <div id="wrapper">

9 <div id="host"></div>	9 <div id="host"></div>

10 </div>	10 </div>

(...skipping 24 matching lines...) Expand all Loading...
35 var nDivs = numDivsInHost;	35 var nDivs = numDivsInHost;

36 var array = window.array;	36 var array = window.array;

37	37

38 var selected = shadowRoot.getElementById('selected');	38 var selected = shadowRoot.getElementById('selected');

39 var nonSelected = shadowRoot.getElementById('nonselected');	39 var nonSelected = shadowRoot.getElementById('nonselected');

40 var contentSelected = selected.querySelector('content');	40 var contentSelected = selected.querySelector('content');

41	41

42 for (var i = 0; i < 100; ++i) {	42 for (var i = 0; i < 100; ++i) {

43 for (var j = 0; j < typeNames.length; ++j) {	43 for (var j = 0; j < typeNames.length; ++j) {

44 contentSelected.select = '.' + typeNames[j];	44 contentSelected.select = '.' + typeNames[j];

45	45 PerfTestRunner.layoutOrFullyRender();

46 selected.offsetLeft;

47 nonSelected.offsetLeft;
Julien - ping for review 2014/11/17 19:05:46 It's bit concerning that if people are not careful It's bit concerning that if people are not careful, they will just miss out our function. Unfortunately offsetLeft / offsetTop / clientHeight are read-only attributes so we can't just modify them on body to alleviate the issue.
48 }	46 }

49 }	47 }

50 }	48 }

51	49

52 function done()	50 function done()

53 {	51 {

54 wrapper.innerHTML = '';	52 wrapper.innerHTML = '';

55 }	53 }

56	54

57	55

58 setup();	56 setup();

59	57

60 PerfTestRunner.measureTime({	58 PerfTestRunner.measureTime({

61 description: "Measure distribution and layout performance when select attrib ute is changed",	59 description: "Measure distribution and layout performance when select attrib ute is changed",

62 run: run,	60 run: run,

63 done: done	61 done: done

64 });	62 });

65 </script>	63 </script>

66 </body>	64 </body>

67 </html>	65 </html>

OLD	NEW