Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 675983002: Add Schedule::InsertBranch to fuse control flow graphs. (Closed)

Created:
6 years, 2 months ago by Michael Starzinger
Modified:
6 years, 2 months ago
Reviewers:
Jarin
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Add Schedule::InsertBranch to fuse control flow graphs. R=jarin@chromium.org TEST=cctest/test-schedule/TestScheduleInsertBranch Committed: https://code.google.com/p/v8/source/detail?r=24876

Patch Set 1 #

Patch Set 2 : Minor cleanup. #

Total comments: 2

Patch Set 3 : Addressed comments by Jaro. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -104 lines) Patch
M src/compiler/schedule.h View 1 2 4 chunks +13 lines, -1 line 0 comments Download
M src/compiler/schedule.cc View 2 chunks +30 lines, -1 line 0 comments Download
M test/cctest/compiler/test-schedule.cc View 4 chunks +40 lines, -8 lines 0 comments Download
M test/cctest/compiler/test-scheduler.cc View 1 2 20 chunks +96 lines, -94 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Starzinger
6 years, 2 months ago (2014-10-24 11:44:27 UTC) #1
Jarin
lgtm. https://codereview.chromium.org/675983002/diff/20001/src/compiler/schedule.h File src/compiler/schedule.h (right): https://codereview.chromium.org/675983002/diff/20001/src/compiler/schedule.h#newcode249 src/compiler/schedule.h:249: // Exposed publicly for testing only. Could you ...
6 years, 2 months ago (2014-10-24 13:21:19 UTC) #2
Michael Starzinger
Addressed comments. Landing. https://codereview.chromium.org/675983002/diff/20001/src/compiler/schedule.h File src/compiler/schedule.h (right): https://codereview.chromium.org/675983002/diff/20001/src/compiler/schedule.h#newcode249 src/compiler/schedule.h:249: // Exposed publicly for testing only. ...
6 years, 2 months ago (2014-10-24 13:44:05 UTC) #3
Michael Starzinger
6 years, 2 months ago (2014-10-24 13:48:14 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:10004) manually as 24876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698