Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 675963002: Use auto, not const auto*, for libyuv function pointers (Closed)

Created:
6 years, 2 months ago by philipj_slow
Modified:
6 years, 2 months ago
CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Use auto, not const auto*, for libyuv function pointers This was a compiler error on GCC 4.9.1: unable to deduce ‘const auto*’ from ‘((((content::PpFrameWriter::FrameWriterDelegate*)this)->content::PpFrameWriter::FrameWriterDelegate::endian_ == (content::PpFrameWriter::FrameWriterDelegate::PixelEndian)1u) ? libyuv::BGRAToI420 : libyuv::ARGBToI420)’ Introduced in https://codereview.chromium.org/663183002 BUG=426020 Committed: https://crrev.com/1694f0d39e4846fbe53ea7f33943502bdd015932 Cr-Commit-Position: refs/heads/master@{#301083}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/renderer/media/webrtc/video_destination_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (3 generated)
philipj_slow
PTAL
6 years, 2 months ago (2014-10-24 10:51:54 UTC) #3
magjed_chromium
If this works, lgtm
6 years, 2 months ago (2014-10-24 11:00:27 UTC) #4
philipj_slow
On 2014/10/24 11:00:27, magjed wrote: > If this works, lgtm It works locally, let's see ...
6 years, 2 months ago (2014-10-24 11:05:15 UTC) #5
perkj_chrome
On 2014/10/24 11:05:15, philipj wrote: > On 2014/10/24 11:00:27, magjed wrote: > > If this ...
6 years, 2 months ago (2014-10-24 11:17:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675963002/1
6 years, 2 months ago (2014-10-24 11:32:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 12:15:46 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 12:16:31 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1694f0d39e4846fbe53ea7f33943502bdd015932
Cr-Commit-Position: refs/heads/master@{#301083}

Powered by Google App Engine
This is Rietveld 408576698