Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 675893002: Revert of Rename BrowserActionView to ToolbarActionView (Closed)

Created:
6 years, 2 months ago by yzshen1
Modified:
6 years, 2 months ago
Reviewers:
Devlin, sky
CC:
chromium-reviews, tfarina, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename BrowserActionView to ToolbarActionView (patchset #1 id:40001 of https://codereview.chromium.org/673503002/) Reason for revert: Failed ComponentToolbarActionsBrowserTest.ComponentToolbarActionsShowUpAndRespondToClicks on Linux ChromiumOS Tests (dbg)(1) and Linux Tests (dbg)(1)(32). [23680:23680:1023/150443:FATAL:browser_actions_container.cc(1021)] Check failed: model_->toolbar_items().size() == toolbar_action_views_.size() (0 vs. 1) Original issue's description: > Rename BrowserActionView to ToolbarActionView > BrowserActionViews now represent significantly more than > just Browser Actions. Rename it to ToolbarActionView. > > BUG=426448 > > Committed: https://crrev.com/fdc6f645c57aa0a054166743d1614ddaf32ab4c0 > Cr-Commit-Position: refs/heads/master@{#300944} TBR=sky@chromium.org,rdevlin.cronin@chromium.org NOTREECHECKS=true NOTRY=true BUG=426448 Committed: https://crrev.com/c336bb11b60a4b5b2b087cad1ccc3d693886707c Cr-Commit-Position: refs/heads/master@{#300964}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+625 lines, -616 lines) Patch
M chrome/browser/ui/views/extensions/extension_installed_bubble_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/extension_message_bubble_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_action_test_util_views.cc View 3 chunks +9 lines, -9 lines 0 comments Download
A chrome/browser/ui/views/toolbar/browser_action_view.h View 1 chunk +166 lines, -0 lines 0 comments Download
A chrome/browser/ui/views/toolbar/browser_action_view.cc View 1 chunk +283 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.h View 10 chunks +43 lines, -41 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container.cc View 30 chunks +86 lines, -86 lines 0 comments Download
M chrome/browser/ui/views/toolbar/browser_actions_container_browsertest.cc View 11 chunks +16 lines, -16 lines 0 comments Download
M chrome/browser/ui/views/toolbar/chevron_menu_button.cc View 7 chunks +11 lines, -11 lines 0 comments Download
M chrome/browser/ui/views/toolbar/component_toolbar_actions_browsertest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
D chrome/browser/ui/views/toolbar/toolbar_action_view.h View 1 chunk +0 lines, -159 lines 0 comments Download
D chrome/browser/ui/views/toolbar/toolbar_action_view.cc View 1 chunk +0 lines, -283 lines 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/toolbar/toolbar_view_interactive_uitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
yzshen1
Created Revert of Rename BrowserActionView to ToolbarActionView
6 years, 2 months ago (2014-10-23 22:36:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675893002/1
6 years, 2 months ago (2014-10-23 22:40:20 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-23 22:42:49 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 22:44:01 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c336bb11b60a4b5b2b087cad1ccc3d693886707c
Cr-Commit-Position: refs/heads/master@{#300964}

Powered by Google App Engine
This is Rietveld 408576698