chrome/test/functional/popups.py - Issue 6758045: Merge 79596 - Modifying the test, popups.PopupsTest.testLaunchBlockedPopupInIncognito, to wait un...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/popups.py

Issue 6758045: Merge 79596 - Modifying the test, popups.PopupsTest.testLaunchBlockedPopupInIncognito, to wait un... (Closed) Base URL: svn://svn.chromium.org/chrome/branches/696/src/

Patch Set: Created 9 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/functional/popups.py

===================================================================

--- chrome/test/functional/popups.py (revision 80082)

+++ chrome/test/functional/popups.py (working copy)

@@ -65,7 +65,10 @@

file_url = self.GetFileURLForPath(os.path.join(

self.DataDir(), 'popup_blocker', 'popup-window-open.html'))

self.NavigateToURL(file_url, 1, 0)

- self.assertEqual(1, len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)))

+ # Wait until the popup is blocked

+ self.assertTrue(self.WaitUntil(lambda:

+ len(self.GetBlockedPopupsInfo(tab_index=0, windex=1)) is 1),

+ msg='Popup not blocked')

self.UnblockAndLaunchBlockedPopup(0, tab_index=0, windex=1)

# Verify that no more popups are blocked

self.assertFalse(self.GetBlockedPopupsInfo(tab_index=0, windex=1))

« no previous file with comments | « no previous file | no next file » | no next file with comments »