Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 675783004: Service Worker: Remove redundant assertions from Cache.put() test case (Closed)

Created:
6 years, 2 months ago by jsbell
Modified:
6 years, 2 months ago
Reviewers:
asanka, jkarlin
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Project:
blink
Visibility:
Public.

Description

Service Worker: Remove redundant assertions from Cache.put() test case Two of the Cache.put() tests were failing because of crbug.com/424629; adjust the assertions so that one test fails (as it should) to track that bug, but relax the assertions in another to verify just the intended behavior (which passes). BUG=374802 R=asanka@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184320

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M LayoutTests/http/tests/serviceworker/cache-put-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/serviceworker/resources/cache-put-worker.js View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
jsbell
I don't know if this CL is worth landing, but I'm trying to pick off ...
6 years, 2 months ago (2014-10-23 20:26:27 UTC) #2
asanka
lgtm
6 years, 2 months ago (2014-10-23 20:33:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675783004/1
6 years, 2 months ago (2014-10-23 22:57:41 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 00:46:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184320

Powered by Google App Engine
This is Rietveld 408576698