Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1351)

Unified Diff: Source/devtools/front_end/main/AdvancedApp.js

Issue 675753002: [DevTools] Drop "ui" module from toolbox. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rootview bug fix Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/devtools/front_end/host/module.json ('k') | Source/devtools/front_end/main/App.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/devtools/front_end/main/AdvancedApp.js
diff --git a/Source/devtools/front_end/main/AdvancedApp.js b/Source/devtools/front_end/main/AdvancedApp.js
index 303969c00a3c1048dee029cf395301303f42833f..ed96d9c0c96eb5df964c726ced6929d2f550b018 100644
--- a/Source/devtools/front_end/main/AdvancedApp.js
+++ b/Source/devtools/front_end/main/AdvancedApp.js
@@ -45,7 +45,11 @@ WebInspector.AdvancedApp.prototype = {
this._toggleEmulationButton.element.classList.toggle("warning", !!message);
},
- presentUI: function()
+ /**
+ * @param {!Document} document
+ * @override
+ */
+ presentUI: function(document)
{
var rootView = new WebInspector.RootView();
@@ -68,7 +72,7 @@ WebInspector.AdvancedApp.prototype = {
WebInspector.inspectorView.showInitialPanel();
console.timeStamp("AdvancedApp.attachToBody");
- rootView.attachToBody();
+ rootView.attachToDocument(document);
this._inspectedPagePlaceholder.update();
},
@@ -88,15 +92,22 @@ WebInspector.AdvancedApp.prototype = {
},
/**
- * @param {!Element} rootElement
+ * @param {!Document} toolboxDocument
* @override
*/
- toolboxLoaded: function(rootElement)
+ toolboxLoaded: function(toolboxDocument)
{
+ WebInspector.initializeUIUtils(toolboxDocument.defaultView);
+ WebInspector.installPortStyles(toolboxDocument);
pfeldman 2014/10/23 14:49:08 I think I removed this one.
dgozman 2014/10/24 11:41:11 Done.
+ WebInspector.ContextMenu.installHandler(toolboxDocument);
+
+ var rootView = new WebInspector.RootView();
var inspectedPagePlaceholder = new WebInspector.InspectedPagePlaceholder();
inspectedPagePlaceholder.addEventListener(WebInspector.InspectedPagePlaceholder.Events.Update, this._onSetInspectedPageBounds.bind(this, true));
this._toolboxResponsiveDesignView = new WebInspector.ResponsiveDesignView(inspectedPagePlaceholder);
- this._toolboxResponsiveDesignView.show(rootElement);
+ this._toolboxResponsiveDesignView.show(rootView.element);
+ rootView.attachToDocument(toolboxDocument);
+
this._updatePageResizer();
},
« no previous file with comments | « Source/devtools/front_end/host/module.json ('k') | Source/devtools/front_end/main/App.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698