Issue 675733003: Cache.put() validation of Request properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 675733003: Cache.put() validation of Request properties (Closed)

Created:
6 years, 2 months ago by jsbell

Modified:
6 years, 2 months ago

Reviewers:
jkarlin

CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Cache.put() validation of Request properties Cache.put() should fail the operation if request's scheme is not "http" or "https", or if the method is not "GET" Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html R=jkarlin@chromium.org BUG=425505 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184310

Patch Set 1 #

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	LayoutTests/http/tests/serviceworker/cache-put-expected.txt	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	Source/modules/serviceworkers/Cache.cpp	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jsbell

jkarlin@ - trivial approach. Not sure this is where we want the validation to happen, ...

6 years, 2 months ago (2014-10-23 19:51:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675733003/1

6 years, 2 months ago (2014-10-23 22:53:39 UTC) #4

commit-bot: I haz the power

6 years, 2 months ago (2014-10-23 23:25:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) as 184310

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages