Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Side by Side Diff: Source/bindings/scripts/v8_interface.py

Issue 675693002: An API returning a Promise should not throw an exceptions [overload version] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright (C) 2013 Google Inc. All rights reserved. 1 # Copyright (C) 2013 Google Inc. All rights reserved.
2 # coding=utf-8 2 # coding=utf-8
3 # 3 #
4 # Redistribution and use in source and binary forms, with or without 4 # Redistribution and use in source and binary forms, with or without
5 # modification, are permitted provided that the following conditions are 5 # modification, are permitted provided that the following conditions are
6 # met: 6 # met:
7 # 7 #
8 # * Redistributions of source code must retain the above copyright 8 # * Redistributions of source code must retain the above copyright
9 # notice, this list of conditions and the following disclaimer. 9 # notice, this list of conditions and the following disclaimer.
10 # * Redistributions in binary form must reproduce the above 10 # * Redistributions in binary form must reproduce the above
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 'deprecate_all_as': common_value(overloads, 'deprecate_as'), # [Depreca teAs] 556 'deprecate_all_as': common_value(overloads, 'deprecate_as'), # [Depreca teAs]
557 'exposed_test_all': common_value(overloads, 'exposed_test'), # [Exposed ] 557 'exposed_test_all': common_value(overloads, 'exposed_test'), # [Exposed ]
558 'has_custom_registration_all': common_value(overloads, 'has_custom_regis tration'), 558 'has_custom_registration_all': common_value(overloads, 'has_custom_regis tration'),
559 'length_tests_methods': length_tests_methods(effective_overloads_by_leng th), 559 'length_tests_methods': length_tests_methods(effective_overloads_by_leng th),
560 # 1. Let maxarg be the length of the longest type list of the 560 # 1. Let maxarg be the length of the longest type list of the
561 # entries in S. 561 # entries in S.
562 'maxarg': lengths[-1], 562 'maxarg': lengths[-1],
563 'measure_all_as': common_value(overloads, 'measure_as'), # [MeasureAs] 563 'measure_all_as': common_value(overloads, 'measure_as'), # [MeasureAs]
564 'minarg': lengths[0], 564 'minarg': lengths[0],
565 'per_context_enabled_function_all': common_value(overloads, 'per_context _enabled_function'), # [PerContextEnabled] 565 'per_context_enabled_function_all': common_value(overloads, 'per_context _enabled_function'), # [PerContextEnabled]
566 'returns_promise_all': promise_overload_count > 0,
566 'runtime_enabled_function_all': common_value(overloads, 'runtime_enabled _function'), # [RuntimeEnabled] 567 'runtime_enabled_function_all': common_value(overloads, 'runtime_enabled _function'), # [RuntimeEnabled]
567 'valid_arities': lengths 568 'valid_arities': lengths
568 # Only need to report valid arities if there is a gap in the 569 # Only need to report valid arities if there is a gap in the
569 # sequence of possible lengths, otherwise invalid length means 570 # sequence of possible lengths, otherwise invalid length means
570 # "not enough arguments". 571 # "not enough arguments".
571 if lengths[-1] - lengths[0] != len(lengths) - 1 else None, 572 if lengths[-1] - lengths[0] != len(lengths) - 1 else None,
572 'visible': has_overload_visible, 573 'visible': has_overload_visible,
573 'has_partial_overloads': has_partial_overloads, 574 'has_partial_overloads': has_partial_overloads,
574 } 575 }
575 576
(...skipping 645 matching lines...) Expand 10 before | Expand all | Expand 10 after
1221 deleter = next( 1222 deleter = next(
1222 method 1223 method
1223 for method in interface.operations 1224 for method in interface.operations
1224 if ('deleter' in method.specials and 1225 if ('deleter' in method.specials and
1225 len(method.arguments) == 1 and 1226 len(method.arguments) == 1 and
1226 str(method.arguments[0].idl_type) == 'DOMString')) 1227 str(method.arguments[0].idl_type) == 'DOMString'))
1227 except StopIteration: 1228 except StopIteration:
1228 return None 1229 return None
1229 1230
1230 return property_deleter(deleter) 1231 return property_deleter(deleter)
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/serviceworker/cache-add-expected.txt ('k') | Source/bindings/templates/methods.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698