Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Side by Side Diff: chrome/browser/resources/extensions/extension_list.js

Issue 675683003: Revert of Hide second 'Details' link on extensions page if App Info dialog used (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git/+/master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 <include src="extension_error.js"> 5 <include src="extension_error.js">
6 6
7 /** 7 /**
8 * The type of the extension data object. The definition is based on 8 * The type of the extension data object. The definition is based on
9 * chrome/browser/ui/webui/extensions/extension_basic_info.cc 9 * chrome/browser/ui/webui/extensions/extension_basic_info.cc
10 * and 10 * and
(...skipping 299 matching lines...) Expand 10 before | Expand all | Expand 10 after
310 // The 'View in Web Store/View Web Site' link. 310 // The 'View in Web Store/View Web Site' link.
311 if (extension.homepageUrl) { 311 if (extension.homepageUrl) {
312 var siteLink = node.querySelector('.site-link'); 312 var siteLink = node.querySelector('.site-link');
313 siteLink.href = extension.homepageUrl; 313 siteLink.href = extension.homepageUrl;
314 siteLink.textContent = loadTimeData.getString( 314 siteLink.textContent = loadTimeData.getString(
315 extension.homepageProvided ? 'extensionSettingsVisitWebsite' : 315 extension.homepageProvided ? 'extensionSettingsVisitWebsite' :
316 'extensionSettingsVisitWebStore'); 316 'extensionSettingsVisitWebStore');
317 siteLink.hidden = false; 317 siteLink.hidden = false;
318 } 318 }
319 319
320 // If the ExtensionInfoDialog is enabled, hide the site link (since it's
321 // available from within the dialog anyway).
322 if (extension.enableExtensionInfoDialog) {
323 siteLink.hidden = true;
324 }
325
326 if (extension.allow_reload) { 320 if (extension.allow_reload) {
327 // The 'Reload' link. 321 // The 'Reload' link.
328 var reload = node.querySelector('.reload-link'); 322 var reload = node.querySelector('.reload-link');
329 reload.addEventListener('click', function(e) { 323 reload.addEventListener('click', function(e) {
330 chrome.send('extensionSettingsReload', [extension.id]); 324 chrome.send('extensionSettingsReload', [extension.id]);
331 extensionReloadedTimestamp[extension.id] = Date.now(); 325 extensionReloadedTimestamp[extension.id] = Date.now();
332 }); 326 });
333 reload.hidden = false; 327 reload.hidden = false;
334 328
335 if (extension.is_platform_app) { 329 if (extension.is_platform_app) {
(...skipping 223 matching lines...) Expand 10 before | Expand all | Expand 10 after
559 $('overlay').addEventListener('cancelOverlay', function() { 553 $('overlay').addEventListener('cancelOverlay', function() {
560 this.optionsShown_ = false; 554 this.optionsShown_ = false;
561 }.bind(this)); 555 }.bind(this));
562 }, 556 },
563 }; 557 };
564 558
565 return { 559 return {
566 ExtensionsList: ExtensionsList 560 ExtensionsList: ExtensionsList
567 }; 561 };
568 }); 562 });
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/resources/extensions/extensions.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698