Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 675683003: Revert of Hide second 'Details' link on extensions page if App Info dialog used (Closed)

Created:
6 years, 2 months ago by qyearsley
Modified:
6 years, 2 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, arv+watch_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org, benwells
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/master
Project:
chromium
Visibility:
Public.

Description

Revert of Hide second 'Details' link on extensions page if App Info dialog used (patchset #5 id:80001 of https://codereview.chromium.org/664473005/) Reason for revert: Caused compile failure: http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20%28dbg%29/builds/15311 Original issue's description: > Hide second 'Details' link on extensions page if App Info dialog used > > Hide the second 'Details' link on extensions page if the Extension > Info Dialog is enabled. Screenshots on bug. > > BUG=395495 > > Committed: https://crrev.com/dd3485a9d6ace73e10d7a55fe24c57e7a42828a2 > Cr-Commit-Position: refs/heads/master@{#301017} TBR=kalman@chromium.org,sashab@chromium.org NOTREECHECKS=true NOTRY=true BUG=395495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/extensions/extension_settings_handler.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
qyearsley
Created Revert of Hide second 'Details' link on extensions page if App Info dialog used
6 years, 2 months ago (2014-10-24 01:47:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675683003/1
6 years, 2 months ago (2014-10-24 01:50:19 UTC) #2
commit-bot: I haz the power
Failed to apply patch for chrome/browser/resources/extensions/extension_list.js: While running git apply --index -3 -p1; error: patch ...
6 years, 2 months ago (2014-10-24 01:51:47 UTC) #4
qyearsley
6 years, 2 months ago (2014-10-24 05:22:33 UTC) #5
Closing this CL.

Powered by Google App Engine
This is Rietveld 408576698