Consolidate Widget Event code, other cleanup.

Consolidate Widget Event code, other cleanup.
Rename *NativeCapture to *MouseCapture.
Rename and move ShouldReleaseCaptureOnMouseReleased.
Move static flag function to Event.

BUG=72040
TEST=Mouse interaction on win & linux_views.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=80065

[msw, 2011-03-30 21:54:03]

Trybots running; touch build works. PTAL

[Ben Goodger (Google), 2011-03-30 23:22:55]

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget.h
File views/widget/widget.h (right):

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget.h#newcod...
views/widget/widget.h:303: bool ProcessMousePressed(const MouseEvent& event);
I want you to rename these methods:

OnMousePressed, OnMouseReleased, OnMouseMoved, OnMouseCaptureLost, and move them
to NativeWidgetDelegate. Then Widget can implement them via that interface.

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget.h#newcod...
views/widget/widget.h:311: // If true, the mouse is currently down.
Can you add a TODO to move these to private:?

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_gtk.cc
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_gtk.cc#n...
views/widget/widget_gtk.cc:1085: ProcessMouseMoved(mouse_event);
Now that you've renamed this method and moved it to NativeWidgetDelegate, this
call becomes:

delegate_->OnMouseMoved(mouse_event);

Also I assume in a future pass you're going to replace the event construction
like so:

delegate_->OnMouseMoved(MouseEvent(event));

?

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_win.cc
File views/widget/widget_win.cc (right):

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_win.cc#n...
views/widget/widget_win.cc:799: ProcessMouseReleased(event));
This is fine for now. I want you to eventually converge on one function on
NativeWidgetDelegate - OnMouseEvent. THat means all this can be condensed to:

if (IsNonClientMessage(message))
  tooltip_manager_->OnMouse(message, w_param, l_param);

MSG msg;
MakeMsg(...);
SetMsgHandled(delegate_->OnMouseEvent(MouseEvent(msg)));

return 0;

Capiche?

[msw, 2011-03-31 14:01:17]

I took a shot at further consolidating and cleaning up this code; PTAL.

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget.h
File views/widget/widget.h (right):

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget.h#newcod...
views/widget/widget.h:303: bool ProcessMousePressed(const MouseEvent& event);
On 2011/03/30 23:22:55, Ben Goodger wrote:
> I want you to rename these methods:
> 
> OnMousePressed, OnMouseReleased, OnMouseMoved, OnMouseCaptureLost, and move
them
> to NativeWidgetDelegate. Then Widget can implement them via that interface.

Done.

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget.h#newcod...
views/widget/widget.h:311: // If true, the mouse is currently down.
On 2011/03/30 23:22:55, Ben Goodger wrote:
> Can you add a TODO to move these to private:?

Done.

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_gtk.cc
File views/widget/widget_gtk.cc (right):

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_gtk.cc#n...
views/widget/widget_gtk.cc:1085: ProcessMouseMoved(mouse_event);
On 2011/03/30 23:22:55, Ben Goodger wrote:
> Now that you've renamed this method and moved it to NativeWidgetDelegate, this
> call becomes:
> 
> delegate_->OnMouseMoved(mouse_event);
> 
> Also I assume in a future pass you're going to replace the event construction
> like so:
> 
> delegate_->OnMouseMoved(MouseEvent(event));
> 
> ?

Done; I'll investigate and document our coordinate systems and translations
soon. At first glance, I'll need to mutate a GdkEvent argument in this widget's
context to support GetContainedWidgetEventCoordinates.

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_win.cc
File views/widget/widget_win.cc (right):

http://codereview.chromium.org/6756043/diff/4001/views/widget/widget_win.cc#n...
views/widget/widget_win.cc:799: ProcessMouseReleased(event));
On 2011/03/30 23:22:55, Ben Goodger wrote:
> This is fine for now. I want you to eventually converge on one function on
> NativeWidgetDelegate - OnMouseEvent. THat means all this can be condensed to:
> 
> if (IsNonClientMessage(message))
>   tooltip_manager_->OnMouse(message, w_param, l_param);
> 
> MSG msg;
> MakeMsg(...);
> SetMsgHandled(delegate_->OnMouseEvent(MouseEvent(msg)));
> 
> return 0;
> 
> Capiche?

Done; I did some of this work now.

[Ben Goodger (Google), 2011-03-31 14:13:03]

One last thing...

http://codereview.chromium.org/6756043/diff/12001/views/widget/native_widget.h
File views/widget/native_widget.h (right):

http://codereview.chromium.org/6756043/diff/12001/views/widget/native_widget....
views/widget/native_widget.h:80: virtual bool
ShouldReleaseCaptureOnMouseReleased() const = 0;
I think this method should be declared/defined on Widget. It is a property of
the Widget not the (platform-specific) NativeWidget.

[msw, 2011-03-31 14:47:25]

Done. We're so close to revision 80000! I want it!

http://codereview.chromium.org/6756043/diff/12001/views/widget/native_widget.h
File views/widget/native_widget.h (right):

http://codereview.chromium.org/6756043/diff/12001/views/widget/native_widget....
views/widget/native_widget.h:80: virtual bool
ShouldReleaseCaptureOnMouseReleased() const = 0;
On 2011/03/31 14:13:03, Ben Goodger wrote:
> I think this method should be declared/defined on Widget. It is a property of
> the Widget not the (platform-specific) NativeWidget.

Done.

[Ben Goodger (Google), 2011-03-31 14:49:36]

LGTM