Issue 6756042: Rename cros_update to cros_portage_upgrade and Updater -> Upgrader.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 6756042: Rename cros_update to cros_portage_upgrade and Updater -> Upgrader. (Closed)

Created:
9 years, 8 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://gitrw.chromium.org:9222/chromite.git@master

Visibility:
Public.

Description

Rename cros_update to cros_portage_upgrade and Updater -> Upgrader. BUG=chromium-os:13591 TEST=ran it Change-Id: I03e94f1b14b0682ea14052c287f9c95724326f4d Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=d89cc05

Patch Set 1 #

Total comments: 2

Created: 9 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -12 lines)			Patch
A	bin/cros_portage_upgrade	View	1 chunk	+1 line, -0 lines	0 comments	Download
A +	bin/cros_portage_upgrade.py	View	8 chunks	+12 lines, -11 lines	2 comments	Download
D	bin/cros_update	View	1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

sosa

LGTM w/ one missing change in a docstring http://codereview.chromium.org/6756042/diff/1/bin/cros_portage_upgrade.py File bin/cros_portage_upgrade.py (right): http://codereview.chromium.org/6756042/diff/1/bin/cros_portage_upgrade.py#newcode123 bin/cros_portage_upgrade.py:123: """Updates ...

9 years, 8 months ago (2011-03-30 18:38:59 UTC) #2

petkov

9 years, 8 months ago (2011-03-30 18:49:48 UTC) #3

http://codereview.chromium.org/6756042/diff/1/bin/cros_portage_upgrade.py
File bin/cros_portage_upgrade.py (right):

http://codereview.chromium.org/6756042/diff/1/bin/cros_portage_upgrade.py#new...
bin/cros_portage_upgrade.py:123: """Updates |info| with latest_cpv and performs
an upgrade if necessary."""
On 2011/03/30 18:38:59, sosa wrote:
> Upgrade?

It does _update_ the map structure and then "_upgrade_ if necessary."

Expand Messages | Collapse Messages