Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 6756040: Merge 82453 - 2011-03-30 Andrey Kosyakov <caseq@chromium.org> (Closed)

Created:
9 years, 8 months ago by podivilov
Modified:
9 years, 4 months ago
Reviewers:
caseq, pfeldman
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/696/
Visibility:
Public.

Description

Merge 82453 - 2011-03-30 Andrey Kosyakov <caseq@chromium.org>; Reviewed by Pavel Feldman. Web Inspector: audit run never completes, fails in DOMAgent.js https://bugs.webkit.org/show_bug.cgi?id=57349 - assure document is present before calling DOMAgent.querySelectAll() * inspector/front-end/AuditRules.js: (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun): 2011-03-30 Andrey Kosyakov <caseq@chromium.org>; Reviewed by Pavel Feldman. Web Inspector: audit run never completes, fails in DOMAgent.js https://bugs.webkit.org/show_bug.cgi?id=57349 * inspector/audits/audits-panel-functional.html: do not select Elements panel before running Audits, this hides bug 57349 BUG=77001 TBR=caseq@chromium.org

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M LayoutTests/inspector/audits/audits-panel-functional.html View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/inspector/front-end/AuditRules.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
podivilov
9 years, 8 months ago (2011-03-30 17:08:29 UTC) #1
podivilov
9 years, 8 months ago (2011-03-30 17:09:29 UTC) #2
podivilov
9 years, 8 months ago (2011-03-30 17:10:47 UTC) #3
caseq
9 years, 8 months ago (2011-03-30 19:13:46 UTC) #4
On 2011/03/30 17:10:47, podivilov wrote:

LGTM.

Powered by Google App Engine
This is Rietveld 408576698