Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 6756001: Removing 'off the record' references. Contributed by vipul.bhasin@gmail.com (Closed)

Created:
9 years, 9 months ago by Vipul
Modified:
9 years, 7 months ago
Reviewers:
markusheintz_
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, pam+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Removing 'off the record' references. Contributed by vipul.bhasin@gmail.com BUG=3333 TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=79988

Patch Set 1 #

Patch Set 2 : Removing off the record references. #

Patch Set 3 : Removing off the record references from the code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -55 lines) Patch
M chrome/browser/content_settings/content_settings_base_provider.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/content_settings/content_settings_base_provider.cc View 7 chunks +12 lines, -12 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_pref_provider.cc View 11 chunks +14 lines, -14 lines 0 comments Download
M chrome/browser/extensions/extensions_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extensions_ui.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/client_side_detection_host_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/proxy_settings_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/devtools_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/slideshow_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sync_internals_html_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/sync_internals_html_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/textfields_ui.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/textfields_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/thumbnail_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/thumbnail_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Vipul
Renamed is_off_the_record to is_incognito in method parameters. Also removed off the record references from BaseProvider ...
9 years, 9 months ago (2011-03-27 17:51:28 UTC) #1
markusheintz_
Thanks a lot for making the naming consistent. Looks good in general, but I think ...
9 years, 9 months ago (2011-03-28 17:37:02 UTC) #2
Vipul
Markus: sure, we should definitely run this through the try bots. I am not a ...
9 years, 9 months ago (2011-03-28 23:48:15 UTC) #3
markusheintz_
LGTM - Thanks a lot for contributing this CL :) Do you need me to ...
9 years, 9 months ago (2011-03-29 13:50:43 UTC) #4
Vipul
9 years, 9 months ago (2011-03-29 23:37:01 UTC) #5
you're welcome :)

yep! I cannot commit so you'll have to do the honors.

Powered by Google App Engine
This is Rietveld 408576698