Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 675563002: Remove mojo/python and gyp targets (Closed)

Created:
6 years, 2 months ago by jamesr
Modified:
6 years, 2 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove mojo/python and gyp targets These are being developed and tested in the mojo repository. The GN rules for the python public targets are still in place for developing mojo applications in the chromium repo. Committed: https://crrev.com/94c09453da4e2600b336d2dd55a224a184f39c64 Cr-Commit-Position: refs/heads/master@{#300740}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1452 lines) Patch
M mojo/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/PRESUBMIT.py View 2 chunks +0 lines, -4 lines 0 comments Download
M mojo/mojo.gyp View 2 chunks +0 lines, -137 lines 0 comments Download
D mojo/mojo_python_unittests.isolate View 1 chunk +0 lines, -22 lines 0 comments Download
M mojo/public/python/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
D mojo/python/BUILD.gn View 1 chunk +0 lines, -27 lines 0 comments Download
D mojo/python/system/mojo/embedder.pyx View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/python/tests/async_wait_unittest.py View 1 chunk +0 lines, -50 lines 0 comments Download
D mojo/python/tests/bindings_constants_unittest.py View 1 chunk +0 lines, -39 lines 0 comments Download
D mojo/python/tests/bindings_enums_unittest.py View 1 chunk +0 lines, -61 lines 0 comments Download
D mojo/python/tests/bindings_serialization_deserialization_unittest.py View 1 chunk +0 lines, -97 lines 0 comments Download
D mojo/python/tests/bindings_structs_unittest.py View 1 chunk +0 lines, -217 lines 0 comments Download
D mojo/python/tests/messaging_unittest.py View 1 chunk +0 lines, -207 lines 0 comments Download
D mojo/python/tests/mojo_unittest.py View 1 chunk +0 lines, -19 lines 0 comments Download
D mojo/python/tests/promise_unittest.py View 1 chunk +0 lines, -181 lines 0 comments Download
D mojo/python/tests/runloop_unittest.py View 1 chunk +0 lines, -41 lines 0 comments Download
D mojo/python/tests/system_unittest.py View 1 chunk +0 lines, -293 lines 0 comments Download
M mojo/tools/mojob.sh View 2 chunks +0 lines, -11 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jamesr
6 years, 2 months ago (2014-10-22 18:09:28 UTC) #2
Ben Goodger (Google)
lgtm
6 years, 2 months ago (2014-10-22 18:19:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675563002/1
6 years, 2 months ago (2014-10-22 18:22:34 UTC) #5
Sam Clegg
Hopefully this should fix 422009 (might want to mention it in the CL desc). Would ...
6 years, 2 months ago (2014-10-22 18:37:53 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-22 20:22:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/94c09453da4e2600b336d2dd55a224a184f39c64 Cr-Commit-Position: refs/heads/master@{#300740}
6 years, 2 months ago (2014-10-22 20:27:43 UTC) #9
jamesr
6 years, 2 months ago (2014-10-22 21:11:59 UTC) #10
Message was sent while issue was closed.
On 2014/10/22 18:37:53, Sam Clegg wrote:
> Hopefully this should fix 422009 (might want to mention it in the CL desc).
> 
> Would you mind running the linux_arm_compile trybot? (don't let it gate the
> landing, but I'm curious how far it will get).

Trying that here: https://codereview.chromium.org/674653002

Powered by Google App Engine
This is Rietveld 408576698