Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1247)

Unified Diff: chrome/browser/history/scored_history_match.h

Issue 67553002: Omnibox Field Trial: Make HQP Score Bookmarks More Highly (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/history/scored_history_match.h
diff --git a/chrome/browser/history/scored_history_match.h b/chrome/browser/history/scored_history_match.h
index 46cfa87e3f71dea307edb72a70b47cbaf1c3ddb4..297ef196bfe385bab725bd4d0a17a00295d90745 100644
--- a/chrome/browser/history/scored_history_match.h
+++ b/chrome/browser/history/scored_history_match.h
@@ -93,6 +93,9 @@ struct ScoredHistoryMatch : public history::HistoryMatch {
// trial state.
static void InitializeAlsoDoHUPLikeScoringFieldAndMaxScoreField();
+ // Sets bookmark_value based on the field trial state.
Peter Kasting 2013/11/09 00:44:55 Nit: Use pipes on member name since it isn't other
Mark P 2013/11/25 21:11:57 Done.
+ static void InitializeBookmarkValue();
+
// An interim score taking into consideration location and completeness
// of the match.
int raw_score;
@@ -126,6 +129,10 @@ struct ScoredHistoryMatch : public history::HistoryMatch {
// The maximum number of recent visits to examine in GetFrecency().
static const size_t kMaxVisitsToScore;
+ // Untyped visits to bookmarked pages score this, compared to 1 for
+ // untyped visits to non-bookmarked pages and 20 for typed visits.
+ static int bookmark_value;
+
// If true, assign raw scores to be max(whatever it normally would be,
// a score that's similar to the score HistoryURL provider would assign).
// This variable is set in the constructor by examining the field trial
« no previous file with comments | « no previous file | chrome/browser/history/scored_history_match.cc » ('j') | chrome/browser/history/scored_history_match.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698