Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 675523002: Revert of Use src-side launcher for telemetry_unittests in chromium_trybot recipe (Closed)

Created:
6 years, 2 months ago by Paweł Hajdan Jr.
Modified:
6 years, 2 months ago
Reviewers:
iannucci
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Revert of Use src-side launcher for telemetry_unittests in chromium_trybot recipe (patchset #2 id:20001 of https://codereview.chromium.org/666023004/) Reason for revert: still breaking :-/ Original issue's description: > Use src-side launcher for telemetry_unittests in chromium_trybot recipe > > Depends on https://codereview.chromium.org/649683005/ > > BUG=422235 > > Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292589 TBR=iannucci@chromium.org NOTREECHECKS=true NOTRY=true BUG=422235 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=292596

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+604 lines, -2174 lines) Patch
M scripts/slave/recipe_modules/chromium/api.py View 1 chunk +0 lines, -29 lines 0 comments Download
M scripts/slave/recipe_modules/chromium/steps.py View 2 chunks +6 lines, -17 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.py View 3 chunks +5 lines, -12 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/arm.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/check_swarming_version_failure.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/checklicenses_failure.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/checkperms_failure.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json View 3 chunks +27 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/deapply_compile_failure_linux.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_arm_compile.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_asan_rel.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_athena_dbg.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_athena_rel.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_clang_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_clang_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_dbg.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_dbg.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_rel.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel_swarming.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clang_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_clang_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg_32.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_dbg.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_swarming.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty32_dbg.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty32_rel.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_dbg.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_rel.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_no_bot_update.json View 3 chunks +25 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg.json View 3 chunks +24 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_openssl_dbg.json View 3 chunks +24 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_openssl_rel.json View 3 chunks +24 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel.json View 3 chunks +24 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_swarming.json View 3 chunks +24 lines, -49 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win8_chromium_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_swarming.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_dbg.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_swarming.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_no_bot_update.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/gclient_runhooks__with_patch__failure.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/invalid_json_without_patch.json View 4 chunks +25 lines, -55 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/no_compile_because_of_analyze.json View 2 chunks +0 lines, -27 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/persistent_failure_and_runhooks_2_fail_test.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/runhooks_failure.json View 1 chunk +0 lines, -21 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json View 3 chunks +24 lines, -48 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json View 3 chunks +24 lines, -48 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_deapply_patch.json View 3 chunks +24 lines, -48 lines 0 comments Download
M scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json View 3 chunks +24 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paweł Hajdan Jr.
Created Revert of Use src-side launcher for telemetry_unittests in chromium_trybot recipe
6 years, 2 months ago (2014-10-22 16:29:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675523002/1
6 years, 2 months ago (2014-10-22 16:30:34 UTC) #2
commit-bot: I haz the power
6 years, 2 months ago (2014-10-22 16:34:45 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as 292596

Powered by Google App Engine
This is Rietveld 408576698