src/hydrogen.cc - Issue 675493002: Move AST node counting to post-pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 675493002: Move AST node counting to post-pass (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Remove duplicate Renumber() call Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 7b1e5b12b0fc1de0a699d9c1dcea2dacdb135ae5..fe70b48a49bc2146e08152003cd19f0c17243e9e 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -7847,8 +7847,7 @@ bool HOptimizedGraphBuilder::TryInline(Handle<JSFunction> target,

// step, but don't transfer ownership to target_info.

target_info.SetAstValueFactory(top_info()->ast_value_factory(), false);

Handle<SharedFunctionInfo> target_shared(target->shared());

- if (!Parser::Parse(&target_info) || !Scope::Analyze(&target_info) ||

- !AstNumbering::Renumber(target_info.function(), target_info.zone())) {

+ if (!Compiler::ParseAndAnalyze(&target_info)) {

if (target_info.isolate()->has_pending_exception()) {

// Parse or scope error, never optimize this function.

SetStackOverflow();