Add tests for RSA private key import using JWK when p and q are swapped.

Add tests for RSA private key import using JWK when p and q are swapped.

BUG=383995
Committed: https://crrev.com/c5b56441a2b8dd13078db6eaa43180b95f39d082
Cr-Commit-Position: refs/heads/master@{#301553}

[eroman, 2014-10-22 19:56:30]

Patchset #1 (id:1) has been deleted

[eroman, 2014-10-22 19:59:12]

Patchset #1 (id:20001) has been deleted

[eroman, 2014-10-22 19:59:31]

eroman@chromium.org changed reviewers:
+ rsleevi@chromium.org

[Ryan Sleevi, 2014-10-24 23:00:57]

LGTM, mod the StatusToString thing, which I don't really like :/

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
File content/child/webcrypto/test/rsa_ssa_unittest.cc (right):

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
content/child/webcrypto/test/rsa_ssa_unittest.cc:1168: blink::WebCryptoKeyFormat
GetKeyFormat(const base::DictionaryValue* test) {
Need a better variable name here? |test| isn't quite descriptive (or at least,
it's not clear if you're saying "This is test data" vs "I'm just testing code
out in my CL")

Suggest test_data

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
File content/child/webcrypto/test/test_helpers.h (right):

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
content/child/webcrypto/test/test_helpers.h:52: std::string StatusToString(const
Status& status);
It's no clear why this is needed over the PrintTo on 43?

[eroman, 2014-10-24 23:07:09]

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
File content/child/webcrypto/test/test_helpers.h (right):

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
content/child/webcrypto/test/test_helpers.h:52: std::string StatusToString(const
Status& status);
On 2014/10/24 23:00:57, Ryan Sleevi wrote:
> It's no clear why this is needed over the PrintTo on 43?

PrintTo() outputs to a stream, as used by gtest.

the *ToString() flavor is so that the expected error can be listed in the test
data (see the "error" field in the new .json file).

[eroman, 2014-10-27 23:35:18]

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
File content/child/webcrypto/test/rsa_ssa_unittest.cc (right):

https://codereview.chromium.org/675453003/diff/120001/content/child/webcrypto...
content/child/webcrypto/test/rsa_ssa_unittest.cc:1168: blink::WebCryptoKeyFormat
GetKeyFormat(const base::DictionaryValue* test) {
On 2014/10/24 23:00:57, Ryan Sleevi wrote:
> Need a better variable name here? |test| isn't quite descriptive (or at least,
> it's not clear if you're saying "This is test data" vs "I'm just testing code
> out in my CL")
> 
> Suggest test_data

Renamed the functions to:

GetKeyFormatForTestCase() / GetKeyDataForTestCase() to try and clarify this.

[eroman, 2014-10-28 00:22:07]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-10-28 00:26:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/675453003/160001

[commit-bot: I haz the power, 2014-10-28 01:17:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-28 01:17:48]

Try jobs failed on following builders:
  mac_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/74322)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[eroman, 2014-10-28 01:22:54]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2014-10-28 01:26:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/675453003/180001

[commit-bot: I haz the power, 2014-10-28 02:28:44]

Committed patchset #8 (id:180001)

[commit-bot: I haz the power, 2014-10-28 02:29:21]

Patchset 8 (id:??) landed as
https://crrev.com/c5b56441a2b8dd13078db6eaa43180b95f39d082
Cr-Commit-Position: refs/heads/master@{#301553}