Split fast/multicol/float-multicol into smaller tests.

Split fast/multicol/float-multicol into smaller tests.

 * float-edge: Tests that floats line up with the edge of the
   column, and not something else.
 * float-break: Tests that tall floats break into columns.
 * float-content-break: Tests that content of floats are broken
   into columns.

R=mstensho@opera.com
BUG=386567
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184505

[andersr, 2014-10-22 11:48:36]

What else do we need to test to kill float-multicol.html? (Other than
vertical-l/r versions).

[mstensho (USE GERRIT), 2014-10-23 08:31:14]

Looks great!

But "multicol" doesn't really have to be part of the file names.

On 2014/10/22 11:48:36, andersr wrote:
> What else do we need to test to kill float-multicol.html? (Other than
> vertical-l/r versions).

Maybe a test where you have a float filled with lines of text, that needs to
break into a next column. Would be nice to see what happens if a line inside a
float needs to be moved to the next column, so that it gets a pagination strut.

This is possible to achieve with float-multicol.html, but only if you make the
window wider, so that you get 2 columns. I get a red "Hola hola 11" in the
second column.

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
File LayoutTests/fast/multicol/float-multicol-break.html (right):

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
LayoutTests/fast/multicol/float-multicol-break.html:8: -webkit-column-width:
160px;
I'd just say -webkit-column-count:3 (or just -webkit-columns:3). Testing how
column-width affects column-count is of course very interesting, but worth a
test on its own, if it doesn't already exist.

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
File LayoutTests/fast/multicol/float-multicol-edge.html (right):

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
LayoutTests/fast/multicol/float-multicol-edge.html:8: -webkit-column-width:
160px;
ditto. Suggest using -webkit-column{s,-count} instead.

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
LayoutTests/fast/multicol/float-multicol-edge.html:19: <p>There should be six
blue floats, one near each edge of each column.</p>
I think we need to express the pass condition in a clearer way.

[andersr, 2014-10-24 09:40:08]

Patch #2: Fixed issues.
Patch #3: Renamed files.
Patch #4: Added test float-content-break. <- PTAL

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
File LayoutTests/fast/multicol/float-multicol-break.html (right):

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
LayoutTests/fast/multicol/float-multicol-break.html:8: -webkit-column-width:
160px;
On 2014/10/23 08:31:14, mstensho wrote:
> I'd just say -webkit-column-count:3 (or just -webkit-columns:3). Testing how
> column-width affects column-count is of course very interesting, but worth a
> test on its own, if it doesn't already exist.

Done.

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
File LayoutTests/fast/multicol/float-multicol-edge.html (right):

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
LayoutTests/fast/multicol/float-multicol-edge.html:8: -webkit-column-width:
160px;
On 2014/10/23 08:31:14, mstensho wrote:
> ditto. Suggest using -webkit-column{s,-count} instead.

Done.

https://codereview.chromium.org/675433002/diff/1/LayoutTests/fast/multicol/fl...
LayoutTests/fast/multicol/float-multicol-edge.html:19: <p>There should be six
blue floats, one near each edge of each column.</p>
On 2014/10/23 08:31:14, mstensho wrote:
> I think we need to express the pass condition in a clearer way.

Rewritten.

[mstensho (USE GERRIT), 2014-10-27 11:04:58]

https://codereview.chromium.org/675433002/diff/60001/LayoutTests/fast/multico...
File LayoutTests/fast/multicol/float-content-break.html (right):

https://codereview.chromium.org/675433002/diff/60001/LayoutTests/fast/multico...
LayoutTests/fast/multicol/float-content-break.html:13: text-align: center;
Looks rather unnecessary.

[andersr, 2014-10-27 16:49:04]

All done. Issues fixed, old tests removed, vertical-lr/rl versions added.

PTAL.

https://codereview.chromium.org/675433002/diff/60001/LayoutTests/fast/multico...
File LayoutTests/fast/multicol/float-content-break.html (right):

https://codereview.chromium.org/675433002/diff/60001/LayoutTests/fast/multico...
LayoutTests/fast/multicol/float-content-break.html:13: text-align: center;
On 2014/10/27 11:04:58, mstensho wrote:
> Looks rather unnecessary.

Done.

[mstensho (USE GERRIT), 2014-10-27 17:25:46]

lgtm, great stuff!

[andersr, 2014-10-28 09:21:45]

The CQ bit was checked by andersr@opera.com

[commit-bot: I haz the power, 2014-10-28 09:22:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/675433002/160001

[commit-bot: I haz the power, 2014-10-28 10:26:46]

Committed patchset #9 (id:160001) as 184505