Source/web/WebLocalFrameImpl.cpp - Issue 675413003: WebLocalFrameImpl::selectWordAroundPosition should select a word before space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 675413003: WebLocalFrameImpl::selectWordAroundPosition should select a word before space. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Use VisibleUnit functions and add test cases Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index 29d679cea19eb70f711694adc53d8f81f36d86bd..246376636260f6c786434784a373fef5691fdb06 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1167,8 +1167,7 @@ bool WebLocalFrameImpl::selectWordAroundCaret()

FrameSelection& selection = frame()->selection();

if (selection.isNone() || selection.isRange())

return false;

- selectWordAroundPosition(frame(), selection.selection().visibleStart());

- return true;

+ return frame()->selection().selectWordAroundPosition(selection.selection().visibleStart());

}

void WebLocalFrameImpl::selectRange(const WebPoint& base, const WebPoint& extent)

« Source/core/editing/FrameSelection.cpp ('K') | « Source/core/editing/FrameSelectionTest.cpp ('k') | no next file » | no next file with comments »