Source/web/WebLocalFrameImpl.cpp - Issue 675413003: WebLocalFrameImpl::selectWordAroundPosition should select a word before space.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebLocalFrameImpl.cpp

Issue 675413003: WebLocalFrameImpl::selectWordAroundPosition should select a word before space. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebLocalFrameImpl.cpp

diff --git a/Source/web/WebLocalFrameImpl.cpp b/Source/web/WebLocalFrameImpl.cpp

index a05d7e3c62780a09594497cb82a7510129560743..1606915fb3313b8631f6da61f9f8b0e5147202bc 100644

--- a/Source/web/WebLocalFrameImpl.cpp

+++ b/Source/web/WebLocalFrameImpl.cpp

@@ -1146,11 +1146,7 @@ WebString WebLocalFrameImpl::selectionAsMarkup() const

void WebLocalFrameImpl::selectWordAroundPosition(LocalFrame* frame, VisiblePosition position)

{

- VisibleSelection selection(position);

- selection.expandUsingGranularity(WordGranularity);

- TextGranularity granularity = selection.isRange() ? WordGranularity : CharacterGranularity;

- frame->selection().setSelection(selection, granularity);

+ frame->selection().selectWordAroundPosition(position);

}

bool WebLocalFrameImpl::selectWordAroundCaret()

« Source/core/editing/FrameSelectionTest.cpp ('K') | « Source/core/editing/FrameSelectionTest.cpp ('k') | no next file » | no next file with comments »