WebLocalFrameImpl::selectWordAroundPosition should select a word before space.

Source/core/editing/FrameSelection.cpp

 /*
  * Copyright (C) 2004, 2008, 2009, 2010 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 54 matching lines @@
 #include "core/rendering/HitTestResult.h"
 #include "core/rendering/InlineTextBox.h"
 #include "core/rendering/RenderLayer.h"
 #include "core/rendering/RenderPart.h"
 #include "core/rendering/RenderText.h"
 #include "core/rendering/RenderTheme.h"
 #include "core/rendering/RenderView.h"
 #include "platform/SecureTextInput.h"
 #include "platform/geometry/FloatQuad.h"
 #include "platform/graphics/GraphicsContext.h"
+#include "platform/text/UnicodeUtilities.h"
 #include "wtf/text/CString.h"
 #include <stdio.h>
 
 #define EDIT_DEBUG 0
 
 namespace blink {
 
 using namespace HTMLNames;
 
 static inline LayoutUnit NoXPosForVerticalArrowNavigation()
@@ skipping 1838 matching lines @@
 }
 
 void FrameSelection::scheduleVisualUpdate() const
 {
     if (!m_frame)
         return;
     if (Page* page = m_frame->page())
         page->animator().scheduleVisualUpdate();
 }
 
+void FrameSelection::selectWordAroundPosition(const VisiblePosition& position)

[yosin_UTC9, 2014/10/28 06:11:46]

Can we use |Position| rather than |VisiblePosition| for ease of use of this
function? It seems this function can work with |Position|.

[yoichio, 2014/10/28 08:28:04]

No, characterAfter and Before are VisiblePosition functions.

+{
+    // If you have a "foo| ", Selection::expandUsingGranularity selects space
+    // after the caret. To select "foo", move |position| to previous.
+    if (isSeparator(position.characterAfter()) && !isSeparator(position.characterBefore())) {

[yosin_UTC9, 2014/10/28 06:11:46]

How about this case "foo |,"?

[yoichio, 2014/10/28 08:28:04]

To search far characters are too aggressive, I think.

+        selectWordAroundPosition(position.previous());
+        return;
+    }
+
+    VisibleSelection selection(position);
+    selection.expandUsingGranularity(WordGranularity);
+    String text = plainText(selection.start(), selection.end());

[yosin_UTC9, 2014/10/28 06:11:46]

Should we check |isSeparator(c)| for character in |text|?

[yoichio, 2014/10/28 08:28:04]

Done.

+    if (text.isEmpty())
+        return;
+
+    setSelection(selection);

[yosin_UTC9, 2014/10/28 06:11:46]

Should we pass |WordGranuaryity| to |setSelection()| as original
|selectWordAroundPosition()|?

[yoichio, 2014/10/28 08:28:04]

Done.

+}
+
 }
 
 #ifndef NDEBUG
 
 void showTree(const blink::FrameSelection& sel)
 {
     sel.showTreeForThis();
 }
 
 void showTree(const blink::FrameSelection* sel)
 {
     if (sel)
         sel->showTreeForThis();
 }
 
 #endif