Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: Source/core/editing/FrameSelectionTest.cpp

Issue 675413003: WebLocalFrameImpl::selectWordAroundPosition should select a word before space. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Adapt to selectWordAroundPosition too Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "core/editing/FrameSelection.h" 6 #include "core/editing/FrameSelection.h"
7 7
8 #include "bindings/core/v8/ExceptionStatePlaceholder.h" 8 #include "bindings/core/v8/ExceptionStatePlaceholder.h"
9 #include "core/dom/Document.h" 9 #include "core/dom/Document.h"
10 #include "core/dom/Element.h" 10 #include "core/dom/Element.h"
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 FrameView& frameView = dummyPageHolder().frameView(); 131 FrameView& frameView = dummyPageHolder().frameView();
132 IntRect frameRect = frameView.frameRect(); 132 IntRect frameRect = frameView.frameRect();
133 frameRect.setWidth(frameRect.width() + 1); 133 frameRect.setWidth(frameRect.width() + 1);
134 frameRect.setHeight(frameRect.height() + 1); 134 frameRect.setHeight(frameRect.height() + 1);
135 dummyPageHolder().frameView().setFrameRect(frameRect); 135 dummyPageHolder().frameView().setFrameRect(frameRect);
136 } 136 }
137 selection().paintCaret(nullptr, LayoutPoint(), LayoutRect()); 137 selection().paintCaret(nullptr, LayoutPoint(), LayoutRect());
138 EXPECT_EQ(startCount, layoutCount()); 138 EXPECT_EQ(startCount, layoutCount());
139 } 139 }
140 140
141 #define EXPECT_EQ_SELECTED_TEXT(text) \
142 EXPECT_EQ(text, WebString(selection().selectedText()).utf8())
143
144 TEST_F(FrameSelectionTest, SelectWordAroundPosition)
145 {
146 // "Foo Bar Baz,"
147 RefPtrWillBeRawPtr<Text> text = document().createTextNode("Foo Bar&nbsp;&nbs p;Baz,");
148 document().body()->appendChild(text);
149 // "Fo|o Bar Baz,"
150 EXPECT_TRUE(selection().selectWordAroundPosition(VisiblePosition(Position(te xt, 2))));
151 EXPECT_EQ_SELECTED_TEXT("Foo");
152 // "Foo| Bar Baz,"
153 EXPECT_TRUE(selection().selectWordAroundPosition(VisiblePosition(Position(te xt, 3))));
154 EXPECT_EQ_SELECTED_TEXT("Foo");
155 // "Foo Bar | Baz,"
156 EXPECT_FALSE(selection().selectWordAroundPosition(VisiblePosition(Position(t ext, 13))));
157 // "Foo Bar Baz|,"
158 EXPECT_TRUE(selection().selectWordAroundPosition(VisiblePosition(Position(te xt, 22))));
159 EXPECT_EQ_SELECTED_TEXT("Baz");
141 } 160 }
161
162 }
OLDNEW
« no previous file with comments | « Source/core/editing/FrameSelection.cpp ('k') | Source/web/WebLocalFrameImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698