Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issue 675403002: Rename CrasAudioClientStubImpl to FakeCrasAudioClient (Closed)

Created:
6 years, 1 month ago by satorux1
Modified:
6 years, 1 month ago
Reviewers:
James Cook, hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, hashimoto+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Rename CrasAudioClientStubImpl to FakeCrasAudioClient CrasAudioClientStubImpl has some fake-ish behavors (ex. SetAudioNodesForTesting). Besides other similar classes in the directory are named FakeWhateverClient. BUG=309506 TEST=none Committed: https://crrev.com/cca5cc1cadd95782faadcca310c9d211a9c03d4f Cr-Commit-Position: refs/heads/master@{#301377}

Patch Set 1 #

Patch Set 2 : fix indentation #

Patch Set 3 : fix the unit test build #

Patch Set 4 : fix the app_shell_unittests build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -291 lines) Patch
M chromeos/audio/cras_audio_handler_unittest.cc View 1 2 6 chunks +9 lines, -9 lines 0 comments Download
M chromeos/chromeos.gyp View 2 chunks +2 lines, -2 lines 0 comments Download
M chromeos/dbus/cras_audio_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
D chromeos/dbus/cras_audio_client_stub_impl.h View 1 chunk +0 lines, -60 lines 0 comments Download
D chromeos/dbus/cras_audio_client_stub_impl.cc View 1 chunk +0 lines, -181 lines 0 comments Download
M chromeos/dbus/dbus_client_bundle.cc View 3 chunks +2 lines, -2 lines 0 comments Download
A + chromeos/dbus/fake_cras_audio_client.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + chromeos/dbus/fake_cras_audio_client.cc View 1 4 chunks +26 lines, -26 lines 0 comments Download
M extensions/shell/browser/shell_audio_controller_chromeos_unittest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
satorux1
6 years, 1 month ago (2014-10-27 05:37:51 UTC) #2
hashimoto
lgtm
6 years, 1 month ago (2014-10-27 05:44:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675403002/20001
6 years, 1 month ago (2014-10-27 06:03:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/5291)
6 years, 1 month ago (2014-10-27 06:52:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675403002/40001
6 years, 1 month ago (2014-10-27 07:03:33 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/5297)
6 years, 1 month ago (2014-10-27 07:40:11 UTC) #11
satorux1
+jamescook for extensions/shell/
6 years, 1 month ago (2014-10-27 07:47:26 UTC) #13
James Cook
lgtm
6 years, 1 month ago (2014-10-27 15:43:36 UTC) #14
James Cook
Since this is just a rename I'll go ahead and CQ it.
6 years, 1 month ago (2014-10-27 15:44:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675403002/60001
6 years, 1 month ago (2014-10-27 15:46:04 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
6 years, 1 month ago (2014-10-27 16:34:08 UTC) #18
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 16:34:57 UTC) #19
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cca5cc1cadd95782faadcca310c9d211a9c03d4f
Cr-Commit-Position: refs/heads/master@{#301377}

Powered by Google App Engine
This is Rietveld 408576698