Issue 675303005: Revert of Autofill: Fix recognition of Walmart ZIP code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 675303005: Revert of Autofill: Fix recognition of Walmart ZIP code. (Closed)

Created:
6 years, 1 month ago by Avi (use Gerrit)

Modified:
6 years, 1 month ago

Reviewers:
Ilya Sherman, Evan Stade

CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Revert of Autofill: Fix recognition of Walmart ZIP code. (patchset #3 id:40001 of https://codereview.chromium.org/676983004/) Reason for revert: The tree exploded with zillions of bots across all platforms failing FormStructureBrowserTest.DataDrivenHeuristics21. FormStructureBrowserTest is autofill, and this is the only autofill change landed around the time everything died. Original issue's description: > Autofill: Fix recognition of Walmart ZIP code. > > BUG=426958 > > Committed: https://crrev.com/dbec51e8134df4f722085ef98144ac0cd207eead > Cr-Commit-Position: refs/heads/master@{#301252} TBR=isherman@chromium.org,estade@chromium.org NOTREECHECKS=true NOTRY=true BUG=426958 Committed: https://crrev.com/a1c646f8a08c62bd68c39a83f811ac08c448f00e Cr-Commit-Position: refs/heads/master@{#301287}

Patch Set 1 #

Created: 6 years, 1 month ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -13 lines)			Patch
	M	chrome/test/data/autofill/heuristics/output/20_checkout_m_walmart.com.out	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	components/autofill/core/browser/address_field.cc	View		1 chunk	+4 lines, -12 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Avi (use Gerrit)

Created Revert of Autofill: Fix recognition of Walmart ZIP code.

6 years, 1 month ago (2014-10-25 17:51:14 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675303005/1

6 years, 1 month ago (2014-10-25 17:53:11 UTC) #2

commit-bot: I haz the power

6 years, 1 month ago (2014-10-25 17:54:51 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a1c646f8a08c62bd68c39a83f811ac08c448f00e
Cr-Commit-Position: refs/heads/master@{#301287}

Expand Messages | Collapse Messages