Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 675283002: Teach missing_from_gn about gn 'inputs' (Closed)

Created:
6 years, 2 months ago by eseidel
Modified:
6 years, 2 months ago
Reviewers:
brettw, abarth-chromium
CC:
mojo-reviews_chromium.org, ojan, esprehn, abarth-chromium
Base URL:
git@github.com:domokit/mojo.git@master
Visibility:
Public.

Description

Teach missing_from_gn about gn 'inputs' Turns out gn has 3 types of sources: inputs (non-source files) sources (source files) public (source files for APIs) I've now taught missing_from_gn about inputs brettw says I can ignore public for now as it's unlikely anyone is using that. R=brettw@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c784b20e129082247abbb55a26dc2ba37cde2417

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -31 lines) Patch
M sky/tools/missing_from_gn View 1 chunk +35 lines, -31 lines 2 comments Download

Messages

Total messages: 6 (1 generated)
eseidel
6 years, 2 months ago (2014-10-24 19:42:16 UTC) #2
eseidel
I'm happy to walk folks through this, and write tests. I figure this script is ...
6 years, 2 months ago (2014-10-24 19:43:30 UTC) #3
brettw
lgtm https://codereview.chromium.org/675283002/diff/1/sky/tools/missing_from_gn File sky/tools/missing_from_gn (right): https://codereview.chromium.org/675283002/diff/1/sky/tools/missing_from_gn#newcode27 sky/tools/missing_from_gn:27: 'gn', 'desc', For "desc" you will have to ...
6 years, 2 months ago (2014-10-24 19:58:47 UTC) #4
eseidel
https://codereview.chromium.org/675283002/diff/1/sky/tools/missing_from_gn File sky/tools/missing_from_gn (right): https://codereview.chromium.org/675283002/diff/1/sky/tools/missing_from_gn#newcode27 sky/tools/missing_from_gn:27: 'gn', 'desc', On 2014/10/24 19:58:47, brettw wrote: > For ...
6 years, 2 months ago (2014-10-24 20:42:59 UTC) #5
eseidel
6 years, 2 months ago (2014-10-24 20:44:49 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c784b20e129082247abbb55a26dc2ba37cde2417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698