Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Issue 675263002: Fix relocation packing in GN (Closed)

Created:
6 years, 2 months ago by cjhopman
Modified:
6 years, 2 months ago
Reviewers:
nyquist
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@gn-packed
Project:
chromium
Visibility:
Public.

Description

Fix relocation packing in GN In GN we pass multiple lists of libraries to the relocation packing script. But, when that script doesn't support that, it just makes the later ones override the earlier ones. Now, it will append all the lists. NOTRY=true BUG=359249 Committed: https://crrev.com/09ac0842aa0603f504d8877b015dc3d04a0b928f Cr-Commit-Position: refs/heads/master@{#301184}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M build/android/gyp/pack_arm_relocations.py View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
cjhopman
newt: *
6 years, 2 months ago (2014-10-24 19:59:08 UTC) #3
cjhopman
nyquist: *
6 years, 2 months ago (2014-10-24 20:02:56 UTC) #5
nyquist
lgtm
6 years, 2 months ago (2014-10-24 20:05:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675263002/20001
6 years, 2 months ago (2014-10-24 20:15:24 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:20001)
6 years, 2 months ago (2014-10-24 20:17:07 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 20:17:56 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/09ac0842aa0603f504d8877b015dc3d04a0b928f
Cr-Commit-Position: refs/heads/master@{#301184}

Powered by Google App Engine
This is Rietveld 408576698