Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1513)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java

Issue 675133002: Export GetLastCommittedEntryIndex and RemoveEntryAtIndex to Java layer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update comments Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java b/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
index 28759ed0d30ebf3d0615f030eb973c17bacbc19d..d039c8eac15574028962198bd4860aab0322fcec 100644
--- a/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/framehost/NavigationControllerImpl.java
@@ -210,6 +210,22 @@ import org.chromium.content_public.browser.NavigationHistory;
return null;
}
+ @Override
+ public int getLastCommittedEntryIndex() {
+ if (mNativeNavigationControllerAndroid != 0) {
+ return nativeGetLastCommittedEntryIndex(mNativeNavigationControllerAndroid);
+ }
+ return -1;
+ }
+
+ @Override
+ public boolean removeEntryAtIndex(int index) {
+ if (mNativeNavigationControllerAndroid != 0) {
+ return nativeRemoveEntryAtIndex(mNativeNavigationControllerAndroid, index);
+ }
+ return false;
+ }
+
@CalledByNative
private static void addToNavigationHistory(Object history, Object navigationEntry) {
((NavigationHistory) history).addEntry((NavigationEntry) navigationEntry);
@@ -264,4 +280,7 @@ import org.chromium.content_public.browser.NavigationHistory;
private native void nativeSetUseDesktopUserAgent(long nativeNavigationControllerAndroid,
boolean override, boolean reloadOnChange);
private native NavigationEntry nativeGetPendingEntry(long nativeNavigationControllerAndroid);
+ private native int nativeGetLastCommittedEntryIndex(long nativeNavigationControllerAndroid);
+ private native boolean nativeRemoveEntryAtIndex(long nativeNavigationControllerAndroid,
+ int index);
}

Powered by Google App Engine
This is Rietveld 408576698