Issue 67513007: Fix PDF browser tests on official waterfalls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 67513007: Fix PDF browser tests on official waterfalls. (Closed)

Created:
7 years, 1 month ago by Paweł Hajdan Jr.

Modified:
7 years, 1 month ago

Reviewers:
jam

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Fix PDF browser tests on official waterfalls. They were making asumptions about current working directory. BUG=320093 R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=236354

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	chrome/browser/ui/pdf/pdf_browsertest.cc	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 4 (0 generated)

jam

lgtm, thank you for tracking this down out of curiosity, what changed? the bot config, ...

7 years, 1 month ago (2013-11-20 04:44:20 UTC) #2

Paweł Hajdan Jr.

On 2013/11/20 04:44:20, jam wrote: > lgtm, thank you for tracking this down > > ...

7 years, 1 month ago (2013-11-20 23:02:12 UTC) #3

Paweł Hajdan Jr.

7 years, 1 month ago (2013-11-21 00:13:47 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r236354 (presubmit successful).