Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 675103003: SupervisedUserService::Delegate: provide default impls of non-required methods (Closed)

Created:
6 years, 2 months ago by Marc Treib
Modified:
6 years, 2 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, pam+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

SupervisedUserService::Delegate: provide default impls of non-required methods BUG= Committed: https://crrev.com/38983df50b2bfbaac0b9b269d54c1408e7b9415f Cr-Commit-Position: refs/heads/master@{#301078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M chrome/browser/supervised_user/supervised_user_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.cc View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Marc Treib
PTAL!
6 years, 2 months ago (2014-10-24 08:22:42 UTC) #3
Marc Treib
PTAL!
6 years, 2 months ago (2014-10-24 08:22:42 UTC) #4
Bernhard Bauer
lgtm
6 years, 2 months ago (2014-10-24 08:41:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675103003/1
6 years, 2 months ago (2014-10-24 08:43:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-24 09:35:22 UTC) #8
commit-bot: I haz the power
6 years, 2 months ago (2014-10-24 09:36:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/38983df50b2bfbaac0b9b269d54c1408e7b9415f
Cr-Commit-Position: refs/heads/master@{#301078}

Powered by Google App Engine
This is Rietveld 408576698