Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Issue 675053002: Move ContentsView::NamedPage to AppListModel::ShowState. (Closed)

Created:
6 years, 2 months ago by calamity
Modified:
6 years, 1 month ago
Reviewers:
Matt Giuca
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git/+/ares_move_search_box_up
Project:
chromium
Visibility:
Public.

Description

Move ContentsView::NamedPage to AppListModel::ShowState. This CL moves the NamedPage enum from ContentsView into AppListModel where it will be used as a more generic value that represents the state of the app list. This is in preparation of notifying code across the chrome/ DEPS boundary of changes to the app list's state. BUG=425444 Committed: https://crrev.com/060d7dc875cc41f46ab264181d1d622d02c3c8b7 Cr-Commit-Position: refs/heads/master@{#301315}

Patch Set 1 : #

Total comments: 4

Patch Set 2 : rename ShowState to State #

Patch Set 3 : fixes #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -73 lines) Patch
M ui/app_list/app_list_model.h View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M ui/app_list/views/app_list_main_view.cc View 1 2 3 3 chunks +5 lines, -6 lines 0 comments Download
M ui/app_list/views/app_list_view_unittest.cc View 1 2 3 7 chunks +18 lines, -20 lines 0 comments Download
M ui/app_list/views/contents_view.h View 1 2 3 5 chunks +16 lines, -21 lines 0 comments Download
M ui/app_list/views/contents_view.cc View 1 2 3 8 chunks +27 lines, -26 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
calamity
6 years, 2 months ago (2014-10-24 02:22:31 UTC) #3
Matt Giuca
lgtm with nits. https://codereview.chromium.org/675053002/diff/40001/ui/app_list/app_list_model.h File ui/app_list/app_list_model.h (right): https://codereview.chromium.org/675053002/diff/40001/ui/app_list/app_list_model.h#newcode43 ui/app_list/app_list_model.h:43: SHOW_APPS, nit: These should be SHOW_STATE_foo. ...
6 years, 2 months ago (2014-10-24 03:23:48 UTC) #5
calamity
https://codereview.chromium.org/675053002/diff/40001/ui/app_list/app_list_model.h File ui/app_list/app_list_model.h (right): https://codereview.chromium.org/675053002/diff/40001/ui/app_list/app_list_model.h#newcode43 ui/app_list/app_list_model.h:43: SHOW_APPS, On 2014/10/24 03:23:48, Matt Giuca wrote: > nit: ...
6 years, 2 months ago (2014-10-24 06:26:35 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675053002/60001
6 years, 2 months ago (2014-10-24 06:30:26 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/83381) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/73026) android_arm64_dbg_recipe ...
6 years, 2 months ago (2014-10-24 06:33:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/675053002/100001
6 years, 1 month ago (2014-10-27 03:17:52 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:100001)
6 years, 1 month ago (2014-10-27 04:58:15 UTC) #13
commit-bot: I haz the power
6 years, 1 month ago (2014-10-27 04:59:24 UTC) #14
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/060d7dc875cc41f46ab264181d1d622d02c3c8b7
Cr-Commit-Position: refs/heads/master@{#301315}

Powered by Google App Engine
This is Rietveld 408576698