chrome/browser/ui/toolbar/wrench_menu_model.cc - Issue 675023002: Make extensions that desire to act pop out if in overflow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model.cc

Issue 675023002: Make extensions that desire to act pop out if in overflow (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Peter's Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/extension_toolbar_model.cc ('K') | « chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm ('k') | chrome/browser/ui/views/toolbar/browser_actions_container.h » ('j') | chrome/browser/ui/views/toolbar/browser_actions_container.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/toolbar/wrench_menu_model.cc

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model.cc b/chrome/browser/ui/toolbar/wrench_menu_model.cc

index 907b472182156981c1a566f5fb0c406a033680e1..850cd608ca133372edfebae496e80aede3b43345 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model.cc

+++ b/chrome/browser/ui/toolbar/wrench_menu_model.cc

@@ -711,7 +711,7 @@ void WrenchMenuModel::CreateExtensionToolbarOverflowMenu() {

extensions::ExtensionToolbarModel* toolbar_model =

extensions::ExtensionToolbarModel::Get(browser_->profile());

// A count of -1 means all actions are visible.

- if (toolbar_model->GetVisibleIconCount() != -1)

+ if (!toolbar_model->all_icons_visible())

AddSeparator(ui::UPPER_SEPARATOR);

#endif // defined(TOOLKIT_VIEWS)

}