Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 675013004: Changing the aging mechanism for script and eval caches. (Closed)

Created:
6 years, 1 month ago by Toon Verwaest
Modified:
6 years, 1 month ago
Reviewers:
ulan
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Changing the aging mechanism for script and eval caches. Instead of using multiple generations for the code, first only store the hash that gets aged. Once a hash matched on a next probe, actually cache the code. Use regular code aging to remove entries from the cache. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=25040

Patch Set 1 #

Patch Set 2 : Cleanup #

Total comments: 1

Patch Set 3 : Adding test #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+183 lines, -36 lines) Patch
M src/compilation-cache.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M src/compilation-cache.cc View 1 5 chunks +12 lines, -25 lines 0 comments Download
M src/objects.h View 1 2 3 2 chunks +13 lines, -0 lines 0 comments Download
M src/objects.cc View 1 7 chunks +66 lines, -8 lines 0 comments Download
M test/cctest/test-heap.cc View 1 2 1 chunk +92 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Toon Verwaest
PTAL
6 years, 1 month ago (2014-10-29 16:47:58 UTC) #2
ulan
Looking good. Please add tests for: - compilation cache doesn't keep SFI and code alive ...
6 years, 1 month ago (2014-10-30 09:25:49 UTC) #3
ulan
lgtm
6 years, 1 month ago (2014-10-31 14:44:48 UTC) #4
Toon Verwaest
6 years, 1 month ago (2014-10-31 14:51:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 25040 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698