Cleanup: Stop creating RenderViewObservers from chrome/ in RenderViewer.

chrome/renderer/render_thread.cc

Index: chrome/renderer/render_thread.cc
===================================================================
--- chrome/renderer/render_thread.cc	(revision 79652)
+++ chrome/renderer/render_thread.cc	(working copy)
@@ -7,6 +7,7 @@
 #include <algorithm>
 #include <limits>
 #include <map>
+#include <set>

[jam, 2011/03/29 18:31:59]

nit: needed?

[Lei Zhang, 2011/03/30 22:05:43]

I was following the linter, but it's a moot point since I reverted all changes
to render_thread.cc.

 #include <vector>
 
 #include "base/command_line.h"
@@ -44,6 +45,7 @@
 #include "chrome/renderer/loadtimes_extension_bindings.h"
 #include "chrome/renderer/net/renderer_net_predictor.h"
 #include "chrome/renderer/render_process_impl.h"
+#include "chrome/renderer/render_view_wrapper.h"

[jam, 2011/03/29 18:31:59]

I'm actually working on removing all the chrome dependencies from RenderThread,
so that I can move it to content (a lot of it is not chrome specific, and will
be needed there, so I don't want to duplicate it).  so my thinking was we would
call through the embedder api (i.e. ContentRendererClient) to inform the
embedder that a RenderView has been created.  then Chrome can add its list of
observers

[Lei Zhang, 2011/03/30 22:05:43]

Ok. I did that in the next patchset.

 #include "chrome/renderer/renderer_histogram_snapshots.h"
 #include "chrome/renderer/safe_browsing/phishing_classifier_delegate.h"
 #include "chrome/renderer/search_extension.h"
@@ -741,16 +743,19 @@
 void RenderThread::OnCreateNewView(const ViewMsg_New_Params& params) {
   EnsureWebKitInitialized();
   // When bringing in render_view, also bring in webkit's glue and jsbindings.
-  RenderView::Create(
+  RenderView* rv = RenderView::Create(
       this,
-      params.parent_window,
-      MSG_ROUTING_NONE,
-      params.renderer_preferences,
       params.web_preferences,
       new SharedRenderViewCounter(0),
       params.view_id,
-      params.session_storage_namespace_id,
-      params.frame_name);
+      params.session_storage_namespace_id);
+  // RenderViewWrapper implements the RenderViewObserver interface and shares
+  // the lifetime of |rv|.
+  new RenderViewWrapper(rv,
+                        params.parent_window,
+                        MSG_ROUTING_NONE,
+                        params.renderer_preferences,
+                        params.frame_name);
 }
 
 void RenderThread::OnSetCacheCapacities(size_t min_dead_capacity,