Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Side by Side Diff: chrome/profile_import/profile_import_thread.cc

Issue 6750010: importer: Cleanup ToolbarImporter code a little bit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/profile_import/profile_import_thread.h" 5 #include "chrome/profile_import/profile_import_thread.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/values.h" 9 #include "base/values.h"
10 #include "chrome/browser/importer/external_process_importer_bridge.h" 10 #include "chrome/browser/importer/external_process_importer_bridge.h"
11 #include "chrome/browser/importer/importer.h"
11 #include "chrome/browser/importer/importer_list.h" 12 #include "chrome/browser/importer/importer_list.h"
12 #include "chrome/browser/importer/importer_messages.h" 13 #include "chrome/browser/importer/importer_messages.h"
13 #include "chrome/browser/search_engines/template_url.h" 14 #include "chrome/browser/search_engines/template_url.h"
14 #include "content/common/child_process.h" 15 #include "content/common/child_process.h"
15 16
16 namespace { 17 namespace {
17 // Rather than sending all import items over IPC at once we chunk them into 18 // Rather than sending all import items over IPC at once we chunk them into
18 // separate requests. This avoids the case of a large import causing 19 // separate requests. This avoids the case of a large import causing
19 // oversized IPC messages. 20 // oversized IPC messages.
20 const int kNumBookmarksToSend = 100; 21 const int kNumBookmarksToSend = 100;
(...skipping 166 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 Send(new ProfileImportProcessHostMsg_NotifyKeywordsReady(urls, 188 Send(new ProfileImportProcessHostMsg_NotifyKeywordsReady(urls,
188 default_keyword_index, unique_on_host_and_path)); 189 default_keyword_index, unique_on_host_and_path));
189 } 190 }
190 191
191 void ProfileImportThread::Cleanup() { 192 void ProfileImportThread::Cleanup() {
192 importer_->Cancel(); 193 importer_->Cancel();
193 importer_ = NULL; 194 importer_ = NULL;
194 bridge_ = NULL; 195 bridge_ = NULL;
195 ChildProcess::current()->ReleaseProcess(); 196 ChildProcess::current()->ReleaseProcess();
196 } 197 }
OLDNEW
« no previous file with comments | « chrome/chrome_browser.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698