Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 674963003: Clean up the individual invalidation tests to be self contained. (Closed)

Created:
6 years, 2 months ago by pdr.
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Clean up the individual invalidation tests to be self contained. This patch cleans up the individual invalidation tests to always call next() directly instead of relying on the previous test to call invokeAsyncWithTimeline. BUG=410701 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -49 lines) Patch
M LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations.html View 1 chunk +22 lines, -18 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-paint-with-layout-invalidations-on-deleted-node.html View 1 chunk +22 lines, -18 lines 0 comments Download
M LayoutTests/inspector/tracing/timeline-paint-with-style-recalc-invalidations.html View 1 chunk +17 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pdr.
6 years, 2 months ago (2014-10-23 18:53:20 UTC) #2
pfeldman
lgtm
6 years, 2 months ago (2014-10-23 18:54:26 UTC) #4
pdr.
On 2014/10/23 at 18:54:26, pfeldman wrote: > lgtm :) Thanks
6 years, 2 months ago (2014-10-23 18:55:19 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674963003/1
6 years, 2 months ago (2014-10-23 18:55:56 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/33347)
6 years, 2 months ago (2014-10-23 21:06:25 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/674963003/1
6 years, 2 months ago (2014-10-23 21:06:53 UTC) #11
commit-bot: I haz the power
6 years, 2 months ago (2014-10-23 21:53:59 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 184304

Powered by Google App Engine
This is Rietveld 408576698