LayoutTests/fast/dom/HTMLImageElement/image-srcset-react-to-media-changes-when-viewport-downsized.html - Issue 674923004: Avoid srcset resource download when higher density resource is in cache.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/HTMLImageElement/image-srcset-react-to-media-changes-when-viewport-downsized.html

Issue 674923004: Avoid srcset resource download when higher density resource is in cache. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed layout tests and added some. Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/HTMLImageElement/image-sizes-2x-expected.txt ('k') | LayoutTests/fast/dom/HTMLImageElement/image-srcset-react-to-media-changes-when-viewport-downsized-expected.txt » ('j') | Source/core/html/parser/HTMLSrcsetParser.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3 <script>	3 <script>

4 var jsTestIsAsync = true;	4 var jsTestIsAsync = true;

5 var img;	5 var img;

6	6

7 onload = function() {	7 onload = function() {

8 var iframe = document.getElementById('frame');	8 var iframe = document.getElementById('frame');

9 var iframeDoc = iframe.contentWindow.document;	9 var iframeDoc = iframe.contentWindow.document;

10	10

11 iframeDoc.body.innerHTML = '<img id="srcset" srcset="resources/blue_rect.jpg 90w, resources/image-set-4x.png 120w">';	11 iframeDoc.body.innerHTML = '<img id="srcset" srcset="resources/blue_rect.jpg 90w, resources/image-set-4x.png 120w">';

12	12

13 img = iframeDoc.getElementById('srcset');	13 img = iframeDoc.getElementById('srcset');

14	14

15 var first = true;	15 var first = true;

16 img.onload = function() {	16 img.onload = function() {

17 if (first) {	17 if (first) {

18 first = false;	18 first = false;

19 shouldNotBe('img.currentSrc.indexOf("blue_rect")', '-1');	19 shouldNotBe('img.currentSrc.indexOf("image-set-4x")', '-1');

20 iframe.style.width = '120px';	20 iframe.style.width = '90px';

	21 setTimeout(function() { finishJSTest(); }, 200);

21 } else {	22 } else {

22 shouldNotBe('img.currentSrc.indexOf("image-set-4x")', '-1');	23 testFailed('onload should not fire a second time');

23 finishJSTest();

24 }	24 }

25 };	25 };

26 img.onerror = function() {	26 img.onerror = function() {

27 testFailed('Image should have loaded');	27 testFailed('Image should have loaded');

28 };	28 };

29 }	29 }

30 </script>	30 </script>

31	31

32 <iframe id="frame" style="width: 80px;"></iframe>	32 <iframe id="frame" style="width: 120px;"></iframe>

OLD	NEW