Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 674913002: Use a simpler KeyedStoreGeneric stub (Closed)

Created:
6 years, 2 months ago by Jakob Kummerow
Modified:
6 years, 1 month ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Use a simpler KeyedStoreGeneric stub R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24941

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -137 lines) Patch
M src/builtins.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 4 chunks +13 lines, -21 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M src/ic/ic.h View 2 chunks +2 lines, -9 lines 0 comments Download
M src/ic/ic.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 4 chunks +9 lines, -15 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 4 chunks +11 lines, -18 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 4 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Jakob Kummerow
Performance neutral in local testing. PTAL.
6 years, 2 months ago (2014-10-23 16:25:43 UTC) #2
Toon Verwaest
lgtm
6 years, 1 month ago (2014-10-27 09:48:45 UTC) #3
Jakob Kummerow
6 years, 1 month ago (2014-10-28 13:54:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:20001) manually as 24941 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698