Issue 674883002: Tweaks to the code serializer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 674883002: Tweaks to the code serializer. (Closed)

Created:
6 years, 2 months ago by Yang

Modified:
6 years, 2 months ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Tweaks to the code serializer. - consider the source string as a special sort of back reference. - use repeat op code for more root members. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24871

Created: 6 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+114 lines, -79 lines)			Patch
M	src/heap/heap.h	View	1 2	4 chunks	+58 lines, -52 lines	0 comments	Download
M	src/heap/heap.cc	View	1 2	1 chunk	+13 lines, -0 lines	0 comments	Download
M	src/hydrogen-instructions.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	src/serialize.h	View	1 2	4 chunks	+24 lines, -7 lines	0 comments	Download
M	src/serialize.cc	View	1 2	5 chunks	+16 lines, -16 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

Yang

On 2014/10/23 14:55:03, Yang wrote: This CL has uncovered a bug: when we encode large ...

6 years, 2 months ago (2014-10-24 11:31:44 UTC) #2

Yang

6 years, 2 months ago (2014-10-24 12:40:19 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as 24871 (presubmit successful).