Add DumpAccessibilityTree tests (6 of 20)

Add DumpAccessibilityTree tests (6 of 20)

HTML Tag: input type reset button, samp, s, dt, progress
ARIA Role: button, dialog, radiogroup
ARIA state/property: aria-live

Following are already present:
HTML Tag input type in date and time state
ARIA state/property: aria-checked

Other changes incorporated in this CL:
1. There should be no STATE_SYSTEM_READONLY for ARIA role dialog.
2. ARIA role radiogroup is exposed correctly.

BUG=170578
Committed: https://crrev.com/fa6fba9f7dd6402a559ade4d119f19ec725e06b6
Cr-Commit-Position: refs/heads/master@{#301573}

[shreeramk, 2014-10-25 15:15:29]

shreeram.k@samsung.com changed reviewers:
+ dmazzoni@chromium.org

[shreeramk, 2014-10-25 15:15:30]

Please review.
Thanks!

[dmazzoni, 2014-10-27 06:00:15]

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
File content/test/data/accessibility/aria-button-expected-android.txt (right):

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
content/test/data/accessibility/aria-button-expected-android.txt:3:
android.widget.ToggleButton checkable
This should be "checked"

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
File content/test/data/accessibility/aria-button-expected-win.txt (right):

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
content/test/data/accessibility/aria-button-expected-win.txt:3:
IA2_ROLE_TOGGLE_BUTTON xml-roles:button checkable:true
I think this should be checked too - unless there's some other way to indicate
that it's currently pressed

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
File content/test/data/accessibility/aria-button.html (right):

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
content/test/data/accessibility/aria-button.html:12: <div role="button"
aria-pressed="true"></div>
Should there be an additional example with aria-pressed="false"? I think that's
different than not having aria-pressed.

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
File content/test/data/accessibility/aria-radiogroup.html (right):

https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
content/test/data/accessibility/aria-radiogroup.html:11: <div tabindex=1
role="radio"></div>
nit: indent this the same as the line above

[shreeramk, 2014-10-27 14:23:16]

On 2014/10/27 06:00:15, dmazzoni wrote:
>
https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
> File content/test/data/accessibility/aria-button-expected-android.txt (right):
> 
>
https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
> content/test/data/accessibility/aria-button-expected-android.txt:3:
> android.widget.ToggleButton checkable
> This should be "checked"
> 
>
https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
> File content/test/data/accessibility/aria-button-expected-win.txt (right):
> 
>
https://codereview.chromium.org/674873004/diff/40001/content/test/data/access...
> content/test/data/accessibility/aria-button-expected-win.txt:3:
> IA2_ROLE_TOGGLE_BUTTON xml-roles:button checkable:true
> I think this should be checked too - unless there's some other way to indicate
> that it's currently pressed
> 

So, would this be like this?

if aria-pressed is true then it would be STATE_SYSTEM_CHECKED,
if aria-pressed is false then nothing
if aria-pressed is mixed then STATE_SYSTEM_MIXED

Or

This is correct bug https://code.google.com/p/chromium/issues/detail?id=171625

[dmazzoni, 2014-10-27 15:17:34]

Aria-pressed is in the ARIA mapping spec here:

http://www.w3.org/TR/wai-aria-implementation/

On Windows, there's a STATE_SYSTEM_PRESSED, so we should use that. Note
that if aria-pressed is present at all, we still set checkable:true.

On Android, we should treat it more like a checkbox, set checkable if
aria-pressed is present, and checked if it's pressed.

On Mon, Oct 27, 2014 at 7:23 AM, <shreeram.k@samsung.com> wrote:

> On 2014/10/27 06:00:15, dmazzoni wrote:
>
> https://codereview.chromium.org/674873004/diff/40001/content/test/data/
> accessibility/aria-button-expected-android.txt
>
>> File content/test/data/accessibility/aria-button-expected-android.txt
>> (right):
>>
>
>
> https://codereview.chromium.org/674873004/diff/40001/content/test/data/
> accessibility/aria-button-expected-android.txt#newcode3
>
>> content/test/data/accessibility/aria-button-expected-android.txt:3:
>> android.widget.ToggleButton checkable
>> This should be "checked"
>>
>
>
> https://codereview.chromium.org/674873004/diff/40001/content/test/data/
> accessibility/aria-button-expected-win.txt
>
>> File content/test/data/accessibility/aria-button-expected-win.txt
>> (right):
>>
>
>
> https://codereview.chromium.org/674873004/diff/40001/content/test/data/
> accessibility/aria-button-expected-win.txt#newcode3
>
>> content/test/data/accessibility/aria-button-expected-win.txt:3:
>> IA2_ROLE_TOGGLE_BUTTON xml-roles:button checkable:true
>> I think this should be checked too - unless there's some other way to
>> indicate
>> that it's currently pressed
>>
>
>
> So, would this be like this?
>
> if aria-pressed is true then it would be STATE_SYSTEM_CHECKED,
> if aria-pressed is false then nothing
> if aria-pressed is mixed then STATE_SYSTEM_MIXED
>
> Or
>
> This is correct bug https://code.google.com/p/chromium/issues/detail?id=
> 171625
>
>
> https://codereview.chromium.org/674873004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[shreeramk, 2014-10-27 16:02:07]

If you don't mind then I would like to skip the expectations for aria-button on
win and android.
I ll fix this with crbug.com/171625.

[dmazzoni, 2014-10-27 16:19:15]

lgtm

Sounds good, thanks

[shreeramk, 2014-10-28 05:15:11]

The CQ bit was checked by shreeram.k@samsung.com

[commit-bot: I haz the power, 2014-10-28 05:16:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/674873004/80001

[commit-bot: I haz the power, 2014-10-28 06:22:53]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2014-10-28 06:23:39]

Patchset 5 (id:??) landed as
https://crrev.com/fa6fba9f7dd6402a559ade4d119f19ec725e06b6
Cr-Commit-Position: refs/heads/master@{#301573}