Add basic console support to Sky's inspector.

Add basic console support to Sky's inspector.

I think longer-term we want to instead fork
InjectedScriptSource.js:
http://blink.lc/blink/tree/Source/core/inspector/InjectedScriptSource.js
since a ton of the "remote object" logic could be shared
between Blink and Sky here.

Since we're trying to talk exactly Chrome's inspector
protocol we should start from the Blink JS as much as possible.

That said, this is enough to get the Chrome devtools
inspector to talk to sky and have the console handle
basic commands!

R=abarth@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/a1a9ad4d6967eb1d80f1a2d1513971d1f4004d6e

[abarth-chromium, 2014-10-29 00:58:25]

lgtm

https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
File sky/framework/inspector/runtime-agent.sky (right):

https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
sky/framework/inspector/runtime-agent.sky:15: }
Should we factor these into a separate module?  They don't seem specific to the
Runtime agent.

https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
sky/framework/inspector/runtime-agent.sky:54: this.objectsById = [];
this.objectsById = new Map() ?

Presumably you'll want to remove objects from this collection in the future.

[pfeldman, 2014-10-29 06:10:37]

This guy implements Debugger and Runtime over raw v8:
https://github.com/repenaxa/node-devtools/blob/master/server.js. It also forks
InjectedScriptSource in a way that could be kept in sync with Blink. I can
update the project and upstream InjectedScriptSource if you are interested in a
quick and hacky way of getting v8 debugging into your picture.

I don't think it is realistic to re-implement DOM, Debugger and other rich
agents without reusing much of the backend code longer term. We have a project
planned that extracts debugger agents and places them next to v8, but there is
nothing like that for DOM. I'm not familiar with how things work for you, but
can you keep some of the native Blink agents running? Anyways, if you have a
question or anything wrt inspector, let me know.

[pfeldman, 2014-10-29 06:12:35]

pfeldman@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2014-10-29 06:12:36]

https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
File sky/framework/inspector/runtime-agent.sky (right):

https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
sky/framework/inspector/runtime-agent.sky:118: value = eval(params.expression);
I need to get this running myself to get to know what worlds this is running in.
I have no idea how you isolate agent code from user land, etc.

[eseidel, 2014-10-29 15:41:41]

Cool, thank you.

Yeah, there is no attempt to isolate code in sky.  The sky app controls the
whole process.  Similar to how GDB just runs code inside your process when
you're debugging it.

[eseidel, 2014-10-29 15:47:14]

Committed patchset #2 (id:20001) manually as
a1a9ad4d6967eb1d80f1a2d1513971d1f4004d6e (presubmit successful).

[eseidel, 2014-10-29 15:48:29]

On 2014/10/29 00:58:25, abarth wrote:
> lgtm
> 
>
https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
> File sky/framework/inspector/runtime-agent.sky (right):
> 
>
https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
> sky/framework/inspector/runtime-agent.sky:15: }
> Should we factor these into a separate module?  They don't seem specific to
the
> Runtime agent.
> 
>
https://codereview.chromium.org/674823003/diff/20001/sky/framework/inspector/...
> sky/framework/inspector/runtime-agent.sky:54: this.objectsById = [];
> this.objectsById = new Map() ?
> 
> Presumably you'll want to remove objects from this collection in the future.

Added some FIXMEs when landing.