Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 674823002: [Regression fix] [Data URI parser] Accept data URI with invalid mediatype data (Closed)

Created:
6 years, 2 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2171
Project:
chromium
Visibility:
Public.

Description

[Regression fix] [Data URI parser] Accept data URI with invalid mediatype data r272022 introduced grammar check on the mediatype part in a data URI. This broke applications that depend on the behavior that our WebURLLoaderImpl and URLRequestDataJob accept data URIs with incomplete mediatype such as "data:image;base64,xxx". Accept this kind of data URI again for backward compatibility. Instead, fallback to the default mediatype when ParseMimeTypeWithoutParameter() returns false in DataURL::Parse() to avoid generating Content-type header with invalid mediatype. BUG=412479 Review URL: https://codereview.chromium.org/555383003 Cr-Commit-Position: refs/heads/master@{#297593} (cherry picked from commit 5469386eaa6bd55fcd5540c570fb535f4d6667e3) Committed: https://chromium.googlesource.com/chromium/src/+/20b5436e589ee79b30a62576dae00ead4cc41136

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -13 lines) Patch
M net/base/data_url.h View 1 chunk +17 lines, -2 lines 0 comments Download
M net/base/data_url.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M net/base/data_url_unittest.cc View 2 chunks +22 lines, -7 lines 0 comments Download
M net/url_request/url_request_data_job_unittest.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 2 months ago (2014-10-23 08:03:07 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
20b5436e589ee79b30a62576dae00ead4cc41136.

Powered by Google App Engine
This is Rietveld 408576698